You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/03/20 10:27:32 UTC
[GitHub] [zeppelin] huage1994 opened a new pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5
huage1994 opened a new pull request #4321:
URL: https://github.com/apache/zeppelin/pull/4321
### What is this PR for?
1. Upgrade junit 4 to 5, then we can write junit 5 tests and migrate junit 4 tests to 5.
2. Run the existing junit 4 tests on Junit 5 engine.
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-5612
### How should this be tested?
CI pass
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4321:
URL: https://github.com/apache/zeppelin/pull/4321#discussion_r830619558
##########
File path: pom.xml
##########
@@ -204,7 +204,7 @@
<plugin.scm.version>1.11.2</plugin.scm.version>
<plugin.shade.version>3.2.2</plugin.shade.version>
<plugin.source.version>3.2.1</plugin.source.version>
- <plugin.surefire.version>2.22.2</plugin.surefire.version>
+ <plugin.surefire.version>3.0.0-M5</plugin.surefire.version>
Review comment:
Is this upgrade required by junit 5?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on a change in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5
Posted by GitBox <gi...@apache.org>.
huage1994 commented on a change in pull request #4321:
URL: https://github.com/apache/zeppelin/pull/4321#discussion_r830636369
##########
File path: pom.xml
##########
@@ -204,7 +204,7 @@
<plugin.scm.version>1.11.2</plugin.scm.version>
<plugin.shade.version>3.2.2</plugin.shade.version>
<plugin.source.version>3.2.1</plugin.source.version>
- <plugin.surefire.version>2.22.2</plugin.surefire.version>
+ <plugin.surefire.version>3.0.0-M5</plugin.surefire.version>
Review comment:
Actually 2.22.2 is ok for junit 5 but I found that 3.0.0-M3 fix some bug about junit 5.
So I upgrade surefire to the latest version.
> [JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine](https://issues.apache.org/jira/browse/SUREFIRE-1614)
> [maven surefire plugin](https://maven.apache.org/surefire/maven-surefire-plugin/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] huage1994 commented on a change in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5
Posted by GitBox <gi...@apache.org>.
huage1994 commented on a change in pull request #4321:
URL: https://github.com/apache/zeppelin/pull/4321#discussion_r830636369
##########
File path: pom.xml
##########
@@ -204,7 +204,7 @@
<plugin.scm.version>1.11.2</plugin.scm.version>
<plugin.shade.version>3.2.2</plugin.shade.version>
<plugin.source.version>3.2.1</plugin.source.version>
- <plugin.surefire.version>2.22.2</plugin.surefire.version>
+ <plugin.surefire.version>3.0.0-M5</plugin.surefire.version>
Review comment:
Actually 2.22.2 is ok for junit 5 but I found that 3.0.0-M3 fix some bug about junit 5.
So I upgrade surefire to the latest version.
> [JUnit Runner that writes to System.out corrupts Surefire's STDOUT when using JUnit's Vintage Engine](https://issues.apache.org/jira/browse/SUREFIRE-1614)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a change in pull request #4321: [ZEPPELIN-5612] Upgrade junit 4 to 5
Posted by GitBox <gi...@apache.org>.
zjffdu commented on a change in pull request #4321:
URL: https://github.com/apache/zeppelin/pull/4321#discussion_r830711116
##########
File path: pom.xml
##########
@@ -204,7 +204,7 @@
<plugin.scm.version>1.11.2</plugin.scm.version>
<plugin.shade.version>3.2.2</plugin.shade.version>
<plugin.source.version>3.2.1</plugin.source.version>
- <plugin.surefire.version>2.22.2</plugin.surefire.version>
+ <plugin.surefire.version>3.0.0-M5</plugin.surefire.version>
Review comment:
Thanks for clarification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org