[GitHub] spark pull request #17715: [SPARK-20047][ML] Constrained Logistic Regression

[yanboliang <gi...@git.apache.org>]

Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17715#discussion_r114248399
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala ---
    @@ -178,11 +178,86 @@ private[classification] trait LogisticRegressionParams extends ProbabilisticClas
         }
       }
     
    +  /**
    +   * The lower bounds on coefficients if fitting under bound constrained optimization.
    +   * The bound matrix must be compatible with the shape (1, number of features) for binomial
    +   * regression, or (number of classes, number of features) for multinomial regression.
    +   * Otherwise, it throws exception.
    +   *
    +   * @group param
    --- End diff --
    
    I agree to put them under expertParams. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org