You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2026/02/15 14:42:23 UTC
[PR] SOLR-18104: Remove deprecated constructor in SnapShooter [solr]
epugh opened a new pull request, #4137:
URL: https://github.com/apache/solr/pull/4137
https://issues.apache.org/jira/browse/SOLR-18104
# Description
This PR is just abut removing a old constructor for SnapShooter that doesn't take in a repo (and therefore internally assumes LocalFileSystemRepository. Basically, when we added the concept of Repository we only modified the code halfway, leaving this method with a deprecation tag.
I THOUGHT this was going to be about removing snapshooter... But alas, it isn't.
# Solution
Modify ReplicationHandler to call SnapShooter propertly.
I noticed taht some parameters are reference that are NOT documented in Ref Guide..
# Tests
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18104: Remove deprecated constructor in SnapShooter [solr]
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #4137:
URL: https://github.com/apache/solr/pull/4137#issuecomment-3908346756
Tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org