You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/24 08:32:58 UTC
[GitHub] [openwhisk-wskdeploy] style95 opened a new pull request #1092:
Remove misleading web-export key
style95 opened a new pull request #1092: Remove misleading web-export key
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1092
`web-export(key)` is being interchangeably used with `web` in `wskdeploy`.
On the other hand, it is differently used in `wsk` cli.
For example, if the `web` flag enabled OW will make the action as a web action and enable the `final` flag. To avoid the use of protected parameters, users can configure two annotations, `web-export(true)` and `final(false)` flag.
But with `wskdeploy`, `web-export` is also being used as a top key of actions and it enables the `final` flag all the time.
Even if users still can control this with annotations, I think it is misleading to have the same option in two different places with two different meanings.
So I removed the top-level one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] style95 commented on issue #1092: Remove
misleading web-export key
Posted by GitBox <gi...@apache.org>.
style95 commented on issue #1092: Remove misleading web-export key
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-612877319
@mrutkows
I initially thought of explicitly specifying the deprecation of the top-level web-export field.
But since both top-level web-export and `annotations.web-export` can coexist, I think it would be enough to just change the top-level one to the annotations' one in all occurrences.
Newbies will start using the `annotation.web-export` as the top-level one is no more exposed.
Do you think we have to explicitly specify the deprecation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] style95 commented on issue #1092: Remove
misleading web-export key
Posted by GitBox <gi...@apache.org>.
style95 commented on issue #1092: Remove misleading web-export key
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604176542
@mrutkows Thank you for the good comment.
I would update it accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows commented on issue #1092: Remove
misleading web-export key
Posted by GitBox <gi...@apache.org>.
mrutkows commented on issue #1092: Remove misleading web-export key
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604126519
There is historical context for this web-export being added at a higher level than annotations... that is, we had intended that wskdeploy manifests would not allow/expose annotations period (at all). However, we were forced by some use cases to add support for it.
My concern is that the code SHOULD still permit the web-export key outside annotations (that is still work and not break anyone using it for 3 years), but deprecate it. Then update all examples use cases to use the annotations, but preserve at least one functional test to make sure that, although deprecated, it still works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-wskdeploy] mrutkows edited a comment on issue #1092:
Remove misleading web-export key
Posted by GitBox <gi...@apache.org>.
mrutkows edited a comment on issue #1092: Remove misleading web-export key
URL: https://github.com/apache/openwhisk-wskdeploy/pull/1092#issuecomment-604126519
@style95 There is historical context for this web-export being added at a higher level than annotations... that is, we had intended that wskdeploy manifests would not allow/expose annotations period (at all). However, we were forced by some use cases to add support for it.
My concern is that the code SHOULD still permit the web-export key outside annotations (that is still work and not break anyone using it for 3 years), but deprecate it. Then update all examples use cases to use the annotations, but preserve at least one functional test to make sure that, although deprecated, it still works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services