You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:47:25 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #6509: Fix test
jingshanglu opened a new pull request #6509:
URL: https://github.com/apache/shardingsphere/pull/6509
Changes proposed in this pull request:
- fix sql parser test case
- simplify sql parser test frame
- check CreateTableStatement
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #6509: Fix test
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #6509:
URL: https://github.com/apache/shardingsphere/pull/6509
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu edited a comment on pull request #6509: Fix test
Posted by GitBox <gi...@apache.org>.
jingshanglu edited a comment on pull request #6509:
URL: https://github.com/apache/shardingsphere/pull/6509#issuecomment-666947784
@tristaZero CreateTable do not have index defined at the end, index define should in ConstraintDefinition, i add it and add assert for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jingshanglu commented on pull request #6509: Fix test
Posted by GitBox <gi...@apache.org>.
jingshanglu commented on pull request #6509:
URL: https://github.com/apache/shardingsphere/pull/6509#issuecomment-666947784
@tristaZero CreateTable should not have index defined at the end, index define should in ConstraintDefinition, i add it and add assert for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org