You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ibessonov (via GitHub)" <gi...@apache.org> on 2023/06/23 08:21:26 UTC
[GitHub] [ignite-3] ibessonov opened a new pull request, #2245: IGNITE-19806 Port of new log storage from "sofa-jraft"
ibessonov opened a new pull request, #2245:
URL: https://github.com/apache/ignite-3/pull/2245
https://issues.apache.org/jira/browse/IGNITE-19806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] Cyrill commented on a diff in pull request #2245: IGNITE-19806 Port new log storage (PR #696) from "sofa-jraft"
Posted by "Cyrill (via GitHub)" <gi...@apache.org>.
Cyrill commented on code in PR #2245:
URL: https://github.com/apache/ignite-3/pull/2245#discussion_r1291153375
##########
build.gradle:
##########
@@ -127,3 +129,12 @@ subprojects {
tasks.register('printSubDependencies', DependencyReportTask)
}
+
+idea.project.settings {
Review Comment:
as mentioned in https://youtrack.jetbrains.com/issue/IDEA-154038,
it might be a better option since it takes the value set on line 93 instead of duplicating:
idea.project.settings.compiler.javac.javacAdditionalOptions = compileJava.options.compilerArgs.join(' ')`
`
##########
build.gradle:
##########
@@ -19,6 +19,7 @@
//This need for resolving plugins in buildscripts
plugins {
id('idea')
+ id 'org.jetbrains.gradle.plugin.idea-ext' version '1.1.7'
Review Comment:
Please declare this plugin in libs.versions.toml` plugins section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #2245: IGNITE-19806 Port new log storage (PR #696) from "sofa-jraft"
Posted by "ibessonov (via GitHub)" <gi...@apache.org>.
ibessonov merged PR #2245:
URL: https://github.com/apache/ignite-3/pull/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org