You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Platob (via GitHub)" <gi...@apache.org> on 2023/04/21 07:15:10 UTC
[GitHub] [arrow] Platob opened a new pull request, #35263: GH-35243: [C#] Implement MapType
Platob opened a new pull request, #35263:
URL: https://github.com/apache/arrow/pull/35263
Implement new MapType with array
need test MapType Struct and Array Builder with values
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1517377904
:warning: GitHub issue #35243 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1517377864
* Closes: #35243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1733945367
@Platob I've taken your branch, merged the latest changes from main and added support for Map in the C API. I'm currently working on adding a few more tests as well as Archery support. Would you like to pull the changes from my branch when I'm done or should I submit a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35243: [C#] Implement MapType [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1749291907
Going to close this since the other PR was merged, but if you want to revisit this please feel free to reopen/file a new issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-35243: [C#] Implement MapType [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed pull request #35263: GH-35243: [C#] Implement MapType
URL: https://github.com/apache/arrow/pull/35263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] CurtHagenlocher commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1734771717
Okay, I'm done with my changes and I pushed them to https://github.com/CurtHagenlocher/arrow/tree/Map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Tommo56700 commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "Tommo56700 (via GitHub)" <gi...@apache.org>.
Tommo56700 commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1717320079
@Platob do you plan to resolve the outstanding conflicts and submit this? I would really appreciate this feature!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Platob commented on pull request #35263: GH-35243: [C#] Implement MapType
Posted by "Platob (via GitHub)" <gi...@apache.org>.
Platob commented on PR #35263:
URL: https://github.com/apache/arrow/pull/35263#issuecomment-1736173362
Damn sorry forgot I still had this pending, thank you @CurtHagenlocher, I did a version where we would need more primary control to scale up on more complex structures, I'm using a version #35299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org