You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-commits@hadoop.apache.org by at...@apache.org on 2012/02/29 02:09:08 UTC
svn commit: r1294923 - in
/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs: ./
src/main/java/org/apache/hadoop/hdfs/
src/main/java/org/apache/hadoop/hdfs/protocol/
src/main/java/org/apache/hadoop/hdfs/protocolPB/ src/main/java/org/apac...
Author: atm
Date: Wed Feb 29 01:09:07 2012
New Revision: 1294923
URL: http://svn.apache.org/viewvc?rev=1294923&view=rev
Log:
HDFS-2920. fix remaining TODO items. Contributed by Aaron T. Myers and Todd Lipcon.
Modified:
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeManagerDatanode.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeObjectDatanode.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMultipleRegistrations.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestRefreshNamenodes.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-1623.txt Wed Feb 29 01:09:07 2012
@@ -238,3 +238,5 @@ HDFS-3013. HA: NameNode format doesn't p
HDFS-3019. Fix silent failure of TestEditLogJournalFailures (todd)
HDFS-2958. Sweep for remaining proxy construction which doesn't go through failover path. (atm)
+
+HDFS-2920. fix remaining TODO items. (atm and todd)
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java Wed Feb 29 01:09:07 2012
@@ -418,22 +418,9 @@ public class DFSClient implements java.i
/**
* Close connections the Namenode.
- * The namenode variable is either a rpcProxy passed by a test or
- * created using the protocolTranslator which is closeable.
- * If closeable then call close, else close using RPC.stopProxy().
*/
void closeConnectionToNamenode() {
- if (namenode instanceof Closeable) {
- try {
- ((Closeable) namenode).close();
- return;
- } catch (IOException e) {
- // fall through - lets try the stopProxy
- LOG.warn("Exception closing namenode, stopping the proxy");
- }
- } else {
- RPC.stopProxy(namenode);
- }
+ RPC.stopProxy(namenode);
}
/** Abort and release resources held. Ignore all errors. */
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/ClientProtocol.java Wed Feb 29 01:09:07 2012
@@ -694,7 +694,6 @@ public interface ClientProtocol extends
*
* @throws IOException
*/
- //TODO(HA): Should this be @Idempotent?
public void finalizeUpgrade() throws IOException;
/**
@@ -704,7 +703,6 @@ public interface ClientProtocol extends
* @return upgrade status information or null if no upgrades are in progress
* @throws IOException
*/
- //TODO(HA): Should this be @Idempotent?
public UpgradeStatusReport distributedUpgradeProgress(UpgradeAction action)
throws IOException;
@@ -737,7 +735,7 @@ public interface ClientProtocol extends
* @param bandwidth Blanacer bandwidth in bytes per second for this datanode.
* @throws IOException
*/
- //TODO(HA): Should this be @Idempotent?
+ @Idempotent
public void setBalancerBandwidth(long bandwidth) throws IOException;
/**
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientDatanodeProtocolTranslatorPB.java Wed Feb 29 01:09:07 2012
@@ -45,6 +45,7 @@ import org.apache.hadoop.ipc.ProtobufHel
import org.apache.hadoop.ipc.ProtobufRpcEngine;
import org.apache.hadoop.ipc.ProtocolMetaInterface;
import org.apache.hadoop.ipc.ProtocolSignature;
+import org.apache.hadoop.ipc.ProtocolTranslator;
import org.apache.hadoop.ipc.RPC;
import org.apache.hadoop.ipc.RpcClientUtil;
import org.apache.hadoop.ipc.RpcPayloadHeader.RpcKind;
@@ -63,7 +64,8 @@ import com.google.protobuf.ServiceExcept
@InterfaceAudience.Private
@InterfaceStability.Stable
public class ClientDatanodeProtocolTranslatorPB implements
- ProtocolMetaInterface, ClientDatanodeProtocol, Closeable {
+ ProtocolMetaInterface, ClientDatanodeProtocol,
+ ProtocolTranslator, Closeable {
public static final Log LOG = LogFactory
.getLog(ClientDatanodeProtocolTranslatorPB.class);
@@ -211,4 +213,9 @@ public class ClientDatanodeProtocolTrans
ClientDatanodeProtocolPB.class, RpcKind.RPC_PROTOCOL_BUFFER,
RPC.getProtocolVersion(ClientDatanodeProtocolPB.class), methodName);
}
+
+ @Override
+ public Object getUnderlyingProxyObject() {
+ return rpcProxy;
+ }
}
\ No newline at end of file
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java Wed Feb 29 01:09:07 2012
@@ -19,7 +19,6 @@ package org.apache.hadoop.hdfs.server.bl
import java.io.IOException;
import java.io.PrintWriter;
-import java.io.StringWriter;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java Wed Feb 29 01:09:07 2012
@@ -383,7 +383,6 @@ class BPOfferService {
bpServices.remove(actor);
- // TODO: synchronization should be a little better here
if (bpServices.isEmpty()) {
dn.shutdownBlockPool(this);
@@ -392,12 +391,6 @@ class BPOfferService {
}
}
- @Deprecated
- synchronized InetSocketAddress getNNSocketAddress() {
- // TODO(HA) this doesn't make sense anymore
- return bpServiceToActive.getNNSocketAddress();
- }
-
/**
* Called by the DN to report an error to the NNs.
*/
@@ -432,11 +425,9 @@ class BPOfferService {
}
/**
- * TODO: this is still used in a few places where we need to sort out
- * what to do in HA!
- * @return a proxy to the active NN
+ * @return a proxy to the active NN, or null if the BPOS has not
+ * acknowledged any NN as active yet.
*/
- @Deprecated
synchronized DatanodeProtocolClientSideTranslatorPB getActiveNN() {
if (bpServiceToActive != null) {
return bpServiceToActive.bpNamenode;
@@ -596,6 +587,7 @@ class BPOfferService {
break;
case DatanodeProtocol.DNA_SHUTDOWN:
// TODO: DNA_SHUTDOWN appears to be unused - the NN never sends this command
+ // See HDFS-2987.
throw new UnsupportedOperationException("Received unimplemented DNA_SHUTDOWN");
case DatanodeProtocol.DNA_REGISTER:
// namenode requested a registration - at start or if NN lost contact
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java Wed Feb 29 01:09:07 2012
@@ -538,8 +538,8 @@ class BPServiceActor implements Runnable
DatanodeCommand cmd = blockReport();
processCommand(new DatanodeCommand[]{ cmd });
- // Now safe to start scanning the block pool
- // TODO(HA): this doesn't seem quite right
+ // Now safe to start scanning the block pool.
+ // If it has already been started, this is a no-op.
if (dn.blockScanner != null) {
dn.blockScanner.addBlockPool(bpos.getBlockPoolId());
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java Wed Feb 29 01:09:07 2012
@@ -86,16 +86,6 @@ class BlockPoolManager {
return bpByBlockPoolId.get(bpid);
}
- // TODO(HA) would be good to kill this
- synchronized BPOfferService get(InetSocketAddress addr) {
- for (BPOfferService bpos : offerServices) {
- if (bpos.containsNN(addr)) {
- return bpos;
- }
- }
- return null;
- }
-
synchronized void remove(BPOfferService t) {
offerServices.remove(t);
bpByBlockPoolId.remove(t.getBlockPoolId());
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java Wed Feb 29 01:09:07 2012
@@ -566,6 +566,23 @@ public class DataNode extends Configured
}
/**
+ * Try to send an error report to the NNs associated with the given
+ * block pool.
+ * @param bpid the block pool ID
+ * @param errCode error code to send
+ * @param errMsg textual message to send
+ */
+ void trySendErrorReport(String bpid, int errCode, String errMsg) {
+ BPOfferService bpos = blockPoolManager.get(bpid);
+ if (bpos == null) {
+ throw new IllegalArgumentException("Bad block pool: " + bpid);
+ }
+ bpos.trySendErrorReport(errCode, errMsg);
+ }
+
+
+
+ /**
* Return the BPOfferService instance corresponding to the given block.
* @param block
* @return the BPOS
@@ -874,7 +891,7 @@ public class DataNode extends Configured
// TODO: all the BPs should have the same name as each other, they all come
// from getName() here! and the use cases only are in tests where they just
// call with getName(). So we could probably just make this method return
- // the first BPOS's registration
+ // the first BPOS's registration. See HDFS-2609.
BPOfferService [] bposArray = blockPoolManager.getAllNamenodeThreads();
for (BPOfferService bpos : bposArray) {
if(bpos.bpRegistration.getName().equals(mName))
@@ -920,22 +937,6 @@ public class DataNode extends Configured
throw new IOException(ie.getMessage());
}
}
-
- /**
- * get the name node address based on the block pool id
- * @param bpid block pool ID
- * @return namenode address corresponding to the bpid
- */
- public InetSocketAddress getNameNodeAddr(String bpid) {
- // TODO(HA) this function doesn't make sense! used by upgrade code
- // Should it return just the active one or simply return the BPService.
- BPOfferService bp = blockPoolManager.get(bpid);
- if (bp != null) {
- return bp.getNNSocketAddress();
- }
- LOG.warn("No name node address found for block pool ID " + bpid);
- return null;
- }
public InetSocketAddress getSelfAddr() {
return selfAddr;
@@ -1869,7 +1870,7 @@ public class DataNode extends Configured
* @return Namenode corresponding to the bpid
* @throws IOException
*/
- public DatanodeProtocolClientSideTranslatorPB getBPNamenode(String bpid)
+ public DatanodeProtocolClientSideTranslatorPB getActiveNamenodeForBP(String bpid)
throws IOException {
BPOfferService bpos = blockPoolManager.get(bpid);
if (bpos == null) {
@@ -1888,9 +1889,13 @@ public class DataNode extends Configured
void syncBlock(RecoveringBlock rBlock,
List<BlockRecord> syncList) throws IOException {
ExtendedBlock block = rBlock.getBlock();
- DatanodeProtocolClientSideTranslatorPB nn = getBPNamenode(block
- .getBlockPoolId());
- assert nn != null;
+ DatanodeProtocolClientSideTranslatorPB nn =
+ getActiveNamenodeForBP(block.getBlockPoolId());
+ if (nn == null) {
+ throw new IOException(
+ "Unable to synchronize block " + rBlock + ", since this DN "
+ + " has not acknowledged any NN as active.");
+ }
long recoveryId = rBlock.getNewGenerationStamp();
if (LOG.isDebugEnabled()) {
@@ -2111,14 +2116,19 @@ public class DataNode extends Configured
/**
* Returned information is a JSON representation of a map with
- * name node host name as the key and block pool Id as the value
+ * name node host name as the key and block pool Id as the value.
+ * Note that, if there are multiple NNs in an NA nameservice,
+ * a given block pool may be represented twice.
*/
@Override // DataNodeMXBean
public String getNamenodeAddresses() {
final Map<String, String> info = new HashMap<String, String>();
for (BPOfferService bpos : blockPoolManager.getAllNamenodeThreads()) {
if (bpos != null) {
- info.put(bpos.getNNSocketAddress().getHostName(), bpos.getBlockPoolId());
+ for (BPServiceActor actor : bpos.getBPServiceActors()) {
+ info.put(actor.getNNSocketAddress().getHostName(),
+ bpos.getBlockPoolId());
+ }
}
}
return JSON.toString(info);
@@ -2167,11 +2177,18 @@ public class DataNode extends Configured
/**
* @param addr rpc address of the namenode
- * @return true - if BPOfferService corresponding to the namenode is alive
+ * @return true if the datanode is connected to a NameNode at the
+ * given address
*/
- public boolean isBPServiceAlive(InetSocketAddress addr) {
- BPOfferService bp = blockPoolManager.get(addr);
- return bp != null ? bp.isAlive() : false;
+ public boolean isConnectedToNN(InetSocketAddress addr) {
+ for (BPOfferService bpos : getAllBpOs()) {
+ for (BPServiceActor bpsa : bpos.getBPServiceActors()) {
+ if (addr.equals(bpsa.getNNSocketAddress())) {
+ return bpsa.isAlive();
+ }
+ }
+ }
+ return false;
}
/**
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeManagerDatanode.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeManagerDatanode.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeManagerDatanode.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeManagerDatanode.java Wed Feb 29 01:09:07 2012
@@ -92,7 +92,7 @@ class UpgradeManagerDatanode extends Upg
"UpgradeManagerDatanode.currentUpgrades is not null.";
assert upgradeDaemon == null :
"UpgradeManagerDatanode.upgradeDaemon is not null.";
- DatanodeProtocol nn = dataNode.getBPNamenode(bpid);
+ DatanodeProtocol nn = dataNode.getActiveNamenodeForBP(bpid);
nn.processUpgradeCommand(broadcastCommand);
return true;
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeObjectDatanode.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeObjectDatanode.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeObjectDatanode.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/UpgradeObjectDatanode.java Wed Feb 29 01:09:07 2012
@@ -45,7 +45,7 @@ public abstract class UpgradeObjectDatan
}
protected DatanodeProtocol getNamenode() throws IOException {
- return dataNode.getBPNamenode(bpid);
+ return dataNode.getActiveNamenodeForBP(bpid);
}
void setDatanode(DataNode dataNode, String bpid) {
@@ -92,14 +92,7 @@ public abstract class UpgradeObjectDatan
+ " Name-node version = " + nsInfo.getLayoutVersion() + ".";
DataNode.LOG.fatal( errorMsg );
String bpid = nsInfo.getBlockPoolID();
- DatanodeProtocol nn = dataNode.getBPNamenode(bpid);
- try {
- nn.errorReport(dataNode.getDNRegistrationForBP(bpid),
- DatanodeProtocol.NOTIFY, errorMsg);
- } catch(SocketTimeoutException e) { // namenode is busy
- DataNode.LOG.info("Problem connecting to server: "
- + dataNode.getNameNodeAddr(nsInfo.getBlockPoolID()));
- }
+ dataNode.trySendErrorReport(bpid, DatanodeProtocol.NOTIFY, errorMsg);
throw new IOException(errorMsg);
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java Wed Feb 29 01:09:07 2012
@@ -282,18 +282,13 @@ public class FSDirectory implements Clos
newNode = new INodeFile(permissions, 0, replication,
modificationTime, atime, preferredBlockSize);
}
- writeLock(); // TODO: this is silly, considering the assert above!
+
try {
- try {
- newNode = addNode(path, newNode, UNKNOWN_DISK_SPACE);
- } catch (IOException e) {
- return null;
- }
- return newNode;
- } finally {
- writeUnlock();
+ newNode = addNode(path, newNode, UNKNOWN_DISK_SPACE);
+ } catch (IOException e) {
+ return null;
}
-
+ return newNode;
}
INodeDirectory addToParent(byte[] src, INodeDirectory parentINode,
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSEditLogLoader.java Wed Feb 29 01:09:07 2012
@@ -266,8 +266,8 @@ public class FSEditLogLoader {
// Now close the file
INodeFileUnderConstruction ucFile = (INodeFileUnderConstruction) oldFile;
- // TODO: we could use removeLease(holder, path) here, but OP_CLOSE
- // doesn't seem to serialize the holder... unclear why!
+ // One might expect that you could use removeLease(holder, path) here,
+ // but OP_CLOSE doesn't serialize the holder. So, remove by path.
fsNamesys.leaseManager.removeLeaseWithPrefixPath(addCloseOp.path);
INodeFile newFile = ucFile.convertToInodeFile();
fsDir.replaceNode(addCloseOp.path, ucFile, newFile);
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImage.java Wed Feb 29 01:09:07 2012
@@ -226,7 +226,6 @@ public class FSImage implements Closeabl
}
}
- // TODO(HA): Have to figure out a story for the first 3 of these.
// 3. Do transitions
switch(startOpt) {
case UPGRADE:
@@ -261,7 +260,6 @@ public class FSImage implements Closeabl
StorageState curState;
try {
curState = sd.analyzeStorage(startOpt, storage);
- // TODO(HA): Fix this.
String nameserviceId = DFSUtil.getNamenodeNameServiceId(conf);
if (curState != StorageState.NORMAL && HAUtil.isHAEnabled(conf, nameserviceId)) {
throw new IOException("Cannot start an HA namenode with name dirs " +
@@ -637,8 +635,6 @@ public class FSImage implements Closeabl
// update the txid for the edit log
editLog.setNextTxId(storage.getMostRecentCheckpointTxId() + numLoaded + 1);
- // TODO(HA): This should probably always return false when HA is enabled and
- // we're coming up in standby state.
return needToSave;
}
@@ -697,8 +693,6 @@ public class FSImage implements Closeabl
} finally {
FSEditLog.closeAllStreams(editStreams);
// update the counts
- // TODO(HA): this may be very slow -- we probably want to
- // update them as we go for HA.
target.dir.updateCountForINodeWithQuota();
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java Wed Feb 29 01:09:07 2012
@@ -533,7 +533,6 @@ public class FSNamesystem implements Nam
if (!editLog.isOpenForWrite()) {
// During startup, we're already open for write during initialization.
- // TODO(HA): consider adding a startup state?
editLog.initJournalsForWrite();
// May need to recover
editLog.recoverUnclosedStreams();
@@ -912,7 +911,6 @@ public class FSNamesystem implements Nam
} finally {
// using finally to ensure we also wait for lease daemon
try {
- // TODO: these lines spew lots of warnings about "already stopped" logs, etc
stopActiveServices();
stopStandbyServices();
if (dir != null) {
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java Wed Feb 29 01:09:07 2012
@@ -920,7 +920,7 @@ public class NameNode {
if (!haEnabled) {
return; // no-op, if HA is not enabled
}
- // TODO:HA implement health check
+ // TODO(HA): implement health check
return;
}
@@ -963,7 +963,7 @@ public class NameNode {
/**
* Class used as expose {@link NameNode} as context to {@link HAState}
*
- * TODO:HA
+ * TODO(HA):
* When entering and exiting state, on failing to start services,
* appropriate action is needed todo either shutdown the node or recover
* from failure.
@@ -1005,7 +1005,6 @@ public class NameNode {
@Override
public void stopStandbyServices() throws IOException {
- // TODO(HA): Are we guaranteed to be the only active here?
if (namesystem != null) {
namesystem.stopStandbyServices();
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyCheckpointer.java Wed Feb 29 01:09:07 2012
@@ -176,7 +176,7 @@ public class StandbyCheckpointer {
public void cancelAndPreventCheckpoints() throws ServiceFailedException {
try {
thread.preventCheckpointsFor(PREVENT_AFTER_CANCEL_MS);
- // TODO: there is a really narrow race here if we are just
+ // TODO(HA): there is a really narrow race here if we are just
// about to start a checkpoint - this won't cancel it!
namesystem.getFSImage().cancelSaveNamespace(
"About to exit standby state");
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java Wed Feb 29 01:09:07 2012
@@ -1696,9 +1696,9 @@ public class MiniDFSCluster {
// If a datanode failed to start, then do not wait
for (DataNodeProperties dn : dataNodes) {
// the datanode thread communicating with the namenode should be alive
- if (!dn.datanode.isBPServiceAlive(addr)) {
- LOG.warn("BPOfferService failed to start in datanode " + dn.datanode
- + " for namenode at " + addr);
+ if (!dn.datanode.isConnectedToNN(addr)) {
+ LOG.warn("BPOfferService in datanode " + dn.datanode
+ + " failed to connect to namenode at " + addr);
return false;
}
}
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestBlockRecovery.java Wed Feb 29 01:09:07 2012
@@ -461,7 +461,7 @@ public class TestBlockRecovery {
initReplicaRecovery(any(RecoveringBlock.class));
Daemon d = spyDN.recoverBlocks(initRecoveringBlocks());
d.join();
- DatanodeProtocol dnP = dn.getBPNamenode(POOL_ID);
+ DatanodeProtocol dnP = dn.getActiveNamenodeForBP(POOL_ID);
verify(dnP).commitBlockSynchronization(
block, RECOVERY_ID, 0, true, true, DatanodeID.EMPTY_ARRAY);
}
@@ -518,7 +518,7 @@ public class TestBlockRecovery {
} catch (IOException e) {
e.getMessage().startsWith("Cannot recover ");
}
- DatanodeProtocol namenode = dn.getBPNamenode(POOL_ID);
+ DatanodeProtocol namenode = dn.getActiveNamenodeForBP(POOL_ID);
verify(namenode, never()).commitBlockSynchronization(
any(ExtendedBlock.class), anyLong(), anyLong(), anyBoolean(),
anyBoolean(), any(DatanodeID[].class));
@@ -547,7 +547,7 @@ public class TestBlockRecovery {
} catch (IOException e) {
e.getMessage().startsWith("Cannot recover ");
}
- DatanodeProtocol namenode = dn.getBPNamenode(POOL_ID);
+ DatanodeProtocol namenode = dn.getActiveNamenodeForBP(POOL_ID);
verify(namenode, never()).commitBlockSynchronization(
any(ExtendedBlock.class), anyLong(), anyLong(), anyBoolean(),
anyBoolean(), any(DatanodeID[].class));
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMultipleRegistrations.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMultipleRegistrations.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMultipleRegistrations.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestDataNodeMultipleRegistrations.java Wed Feb 29 01:09:07 2012
@@ -23,6 +23,8 @@ import static org.junit.Assert.assertNot
import static org.junit.Assert.assertNotSame;
import java.io.IOException;
+import java.net.InetSocketAddress;
+import java.util.List;
import java.util.Map;
import org.apache.commons.logging.Log;
@@ -99,15 +101,15 @@ public class TestDataNodeMultipleRegistr
BPOfferService bpos2 = dn.getAllBpOs()[1];
// The order of bpos is not guaranteed, so fix the order
- if (bpos1.getNNSocketAddress().equals(nn2.getNameNodeAddress())) {
+ if (getNNSocketAddress(bpos1).equals(nn2.getNameNodeAddress())) {
BPOfferService tmp = bpos1;
bpos1 = bpos2;
bpos2 = tmp;
}
- assertEquals("wrong nn address", bpos1.getNNSocketAddress(),
+ assertEquals("wrong nn address", getNNSocketAddress(bpos1),
nn1.getNameNodeAddress());
- assertEquals("wrong nn address", bpos2.getNNSocketAddress(),
+ assertEquals("wrong nn address", getNNSocketAddress(bpos2),
nn2.getNameNodeAddress());
assertEquals("wrong bpid", bpos1.getBlockPoolId(), bpid1);
assertEquals("wrong bpid", bpos2.getBlockPoolId(), bpid2);
@@ -121,6 +123,12 @@ public class TestDataNodeMultipleRegistr
cluster.shutdown();
}
}
+
+ private static InetSocketAddress getNNSocketAddress(BPOfferService bpos) {
+ List<BPServiceActor> actors = bpos.getBPServiceActors();
+ assertEquals(1, actors.size());
+ return actors.get(0).getNNSocketAddress();
+ }
/**
* starts single nn and single dn and verifies registration and handshake
@@ -154,14 +162,16 @@ public class TestDataNodeMultipleRegistr
for (BPOfferService bpos : dn.getAllBpOs()) {
LOG.info("reg: bpid=" + "; name=" + bpos.bpRegistration.name + "; sid="
- + bpos.bpRegistration.storageID + "; nna=" + bpos.getNNSocketAddress());
+ + bpos.bpRegistration.storageID + "; nna=" +
+ getNNSocketAddress(bpos));
}
// try block report
BPOfferService bpos1 = dn.getAllBpOs()[0];
bpos1.triggerBlockReportForTests();
- assertEquals("wrong nn address", bpos1.getNNSocketAddress(),
+ assertEquals("wrong nn address",
+ getNNSocketAddress(bpos1),
nn1.getNameNodeAddress());
assertEquals("wrong bpid", bpos1.getBlockPoolId(), bpid1);
assertEquals("wrong cid", dn.getClusterId(), cid1);
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestRefreshNamenodes.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestRefreshNamenodes.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestRefreshNamenodes.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/TestRefreshNamenodes.java Wed Feb 29 01:09:07 2012
@@ -22,15 +22,18 @@ import static org.junit.Assert.*;
import java.io.IOException;
import java.net.InetSocketAddress;
+import java.util.Set;
import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.hdfs.DFSConfigKeys;
import org.apache.hadoop.hdfs.MiniDFSCluster;
import org.apache.hadoop.hdfs.MiniDFSNNTopology;
import org.apache.hadoop.hdfs.MiniDFSNNTopology.NNConf;
import org.apache.hadoop.hdfs.MiniDFSNNTopology.NSConf;
import org.junit.Test;
+import com.google.common.base.Joiner;
+import com.google.common.collect.Sets;
+
/**
* Tests datanode refresh namenode list functionality.
*/
@@ -65,21 +68,24 @@ public class TestRefreshNamenodes {
cluster.addNameNode(conf, nnPort4);
- BPOfferService[] bpoList = dn.getAllBpOs();
// Ensure a BPOfferService in the datanodes corresponds to
// a namenode in the cluster
+ Set<InetSocketAddress> nnAddrsFromCluster = Sets.newHashSet();
for (int i = 0; i < 4; i++) {
- InetSocketAddress addr = cluster.getNameNode(i).getNameNodeAddress();
- boolean found = false;
- for (int j = 0; j < bpoList.length; j++) {
- if (bpoList[j] != null && addr.equals(bpoList[j].getNNSocketAddress())) {
- found = true;
- bpoList[j] = null; // Erase the address that matched
- break;
- }
+ assertTrue(nnAddrsFromCluster.add(
+ cluster.getNameNode(i).getNameNodeAddress()));
+ }
+
+ Set<InetSocketAddress> nnAddrsFromDN = Sets.newHashSet();
+ for (BPOfferService bpos : dn.getAllBpOs()) {
+ for (BPServiceActor bpsa : bpos.getBPServiceActors()) {
+ assertTrue(nnAddrsFromDN.add(bpsa.getNNSocketAddress()));
}
- assertTrue("NameNode address " + addr + " is not found.", found);
}
+
+ assertEquals("",
+ Joiner.on(",").join(
+ Sets.symmetricDifference(nnAddrsFromCluster, nnAddrsFromDN)));
} finally {
if (cluster != null) {
cluster.shutdown();
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestPipelinesFailover.java Wed Feb 29 01:09:07 2012
@@ -179,7 +179,7 @@ public class TestPipelinesFailover {
// write another block and a half
AppendTestUtil.write(stm, BLOCK_AND_A_HALF, BLOCK_AND_A_HALF);
- stm.hflush(); // TODO: see above
+ stm.hflush();
LOG.info("Failing back to NN 0");
cluster.transitionToStandby(0);
@@ -188,7 +188,7 @@ public class TestPipelinesFailover {
cluster.stopDataNode(1);
AppendTestUtil.write(stm, BLOCK_AND_A_HALF*2, BLOCK_AND_A_HALF);
- stm.hflush(); // TODO: see above
+ stm.hflush();
stm.close();
Modified: hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java
URL: http://svn.apache.org/viewvc/hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java?rev=1294923&r1=1294922&r2=1294923&view=diff
==============================================================================
--- hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java (original)
+++ hadoop/common/branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestStandbyCheckpoints.java Wed Feb 29 01:09:07 2012
@@ -127,9 +127,6 @@ public class TestStandbyCheckpoints {
List<File> dirs = Lists.newArrayList();
dirs.addAll(FSImageTestUtil.getNameNodeCurrentDirs(cluster, 0));
dirs.addAll(FSImageTestUtil.getNameNodeCurrentDirs(cluster, 1));
- // TODO: this failed once because it caught a ckpt file -- maybe
- // this is possible if one of the NNs is really fast and the other is slow?
- // need to loop this to suss out the race.
FSImageTestUtil.assertParallelFilesAreIdentical(dirs, ImmutableSet.<String>of());
}