You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by Jim Marino <jm...@myromatours.com> on 2007/01/02 20:18:51 UTC
Databinding interceptor
Raymond, maybe you could answer this...
I've noticed that the Databinding interceptor seems to be getting
added to all wires, regardless of whether it is needed or not. Is
this correct? If so, we should change the behavior of the post
processor to only add the interceptor when needed, otherwise we will
not be able to optimize wires (and also avoid the overhead of an
additional method call).
Jim
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: Databinding interceptor
Posted by Jim Marino <jm...@myromatours.com>.
I think the problem is here:
if (sourceDataBinding == null || targetDataBinding == null
|| !sourceDataBinding.equals(targetDataBinding)) {
The databinding interceptor should not be interposed if the
databindings are undefined.
Jim
On Jan 2, 2007, at 11:26 AM, Raymond Feng wrote:
> Hi,
>
> I think we have some checks (test if the databindings are equal for
> source and target operations) before adding the interceptor. This
> might not be fully optimized.
>
> Thanks,
> Raymond
>
> ----- Original Message ----- From: "Jim Marino"
> <jm...@myromatours.com>
> To: <tu...@ws.apache.org>
> Sent: Tuesday, January 02, 2007 11:18 AM
> Subject: Databinding interceptor
>
>
>> Raymond, maybe you could answer this...
>>
>> I've noticed that the Databinding interceptor seems to be getting
>> added to all wires, regardless of whether it is needed or not. Is
>> this correct? If so, we should change the behavior of the post
>> processor to only add the interceptor when needed, otherwise we
>> will not be able to optimize wires (and also avoid the overhead
>> of an additional method call).
>>
>> Jim
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
>> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: Databinding interceptor
Posted by Raymond Feng <en...@gmail.com>.
Hi,
I think we have some checks (test if the databindings are equal for source
and target operations) before adding the interceptor. This might not be
fully optimized.
Thanks,
Raymond
----- Original Message -----
From: "Jim Marino" <jm...@myromatours.com>
To: <tu...@ws.apache.org>
Sent: Tuesday, January 02, 2007 11:18 AM
Subject: Databinding interceptor
> Raymond, maybe you could answer this...
>
> I've noticed that the Databinding interceptor seems to be getting added
> to all wires, regardless of whether it is needed or not. Is this correct?
> If so, we should change the behavior of the post processor to only add
> the interceptor when needed, otherwise we will not be able to optimize
> wires (and also avoid the overhead of an additional method call).
>
> Jim
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org