[GitHub] [iceberg] jackye1995 edited a comment on pull request #2701: Hive: support create table with partition transform through table property

[GitBox <gi...@apache.org>]

jackye1995 edited a comment on pull request #2701:
URL: https://github.com/apache/iceberg/pull/2701#issuecomment-870939440


   @yyanyy there are 2 things we have to address here:
   1. parsing columns with `,` in transform, such as `bucket(16, i,d)`
   2. parsing columns with `|`: such as `col1|co|l2`
   
   I don't see a good way to use a hybrid approach of regex + character parsing to address this and keep the user experience consistent.
   
   Based on what Spark has, since we are already using a character parsing approach, it might be better to directly use `,` as delimiter, and also support the `transform AS fieldName` syntax, so we can specify something like `bucket(16,id) AS shard, category`. I will update based on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org