You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/05/19 06:38:53 UTC

[kudu-CR] [webui] Add rudimentary balance info to /table

Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10461


Change subject: [webui] Add rudimentary balance info to /table
......................................................................

[webui] Add rudimentary balance info to /table

See what it looks like at:

https://github.com/wdberkeley/kudu/blob/rbweb/www/tablebalancesection.png

Clicking the (?) pops out a quick explanation of what skew is, the same
way as the (?)'s work on /config.

Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 47 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/10461/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9
Gerrit-Change-Number: 10461
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>

[kudu-CR] [webui] Add rudimentary balance info to /table

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10461 )

Change subject: [webui] Add rudimentary balance info to /table
......................................................................

[webui] Add rudimentary balance info to /table

See what it looks like at:

https://github.com/wdberkeley/kudu/blob/rbweb/www/tablebalancesection.png

Clicking the (?) pops out a quick explanation of what skew is, the same
way as the (?)'s work on /config.

Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9
Reviewed-on: http://gerrit.cloudera.org:8080/10461
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/master_path_handlers.cc
M www/table.mustache
2 files changed, 47 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Alexey Serbin: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9
Gerrit-Change-Number: 10461
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] [webui] Add rudimentary balance info to /table

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10461 )

Change subject: [webui] Add rudimentary balance info to /table
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10461
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb6e29c10e7d5a3a48ea11438c54576664703bb9
Gerrit-Change-Number: 10461
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 19 May 2018 19:50:30 +0000
Gerrit-HasComments: No