You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wayang.apache.org by Mirko Kämpf <mi...@gmail.com> on 2023/10/10 11:50:55 UTC
PR Ready for review
Dear Apache Wayang community,
Here is a pull request which brings the ability to read remote files from a
webserver via https protocol.
https://github.com/apache/incubator-wayang/pull/348
I added a test new class, a test data file, and modified the
*JavaTextFileSource.java* class.
Best wishes,
Mirko
--
Dr. rer. nat. Mirko Kämpf
Müchelner Str. 23
06259 Frankleben
Re: PR Ready for review
Posted by Kaustubh Beedkar <kb...@gmail.com>.
Yes, that might be the case. I just checked, and the 'on' in the workflow
on the rel branch is set to main branch. Hence, no actions were triggered.
If I remember correctly, we agreed to use the main branch for development.
Kaustubh
On Tue, Oct 10, 2023 at 6:12 PM Zoi Kaoudi <zk...@yahoo.gr.invalid> wrote:
> I think Mirko's PR was in branch rel/0.7.1 and the rest of the PRs are in
> the main branch. Maybe there are no workflows in rel/0.7.1 branch. BTW, I
> don't remember what we agreed for the developing branch, is it the main
> one?
>
> We need @Glaucia to clarify things ;)
> Best
> --
> Zoi
>
> Στις Τρίτη 10 Οκτωβρίου 2023 στις 02:38:24 μ.μ. CEST, ο χρήστης
> Kaustubh Beedkar <kb...@gmail.com> έγραψε:
>
> I just merged the PR. Thanks, @Mirko for the contribution.
>
> @Zoi that is strange. could it be that the workflow was not triggered?
>
> Best,
> Kaustubh
>
>
> On Tue, Oct 10, 2023 at 5:32 PM Zoi Kaoudi <zk...@yahoo.gr.invalid>
> wrote:
>
> > Thanks a lot Mirko. The PR looks good to me.
> > However, I do not see the usual checks that we have for PRs.@Glaucia:
> any
> > idea why is that?
> > Best
> > --
> > Zoi
> >
> > Στις Τρίτη 10 Οκτωβρίου 2023 στις 01:52:00 μ.μ. CEST, ο χρήστης Mirko
> > Kämpf <mi...@gmail.com> έγραψε:
> >
> > Dear Apache Wayang community,
> >
> > Here is a pull request which brings the ability to read remote files
> from a
> > webserver via https protocol.
> >
> > https://github.com/apache/incubator-wayang/pull/348
> >
> > I added a test new class, a test data file, and modified the
> > *JavaTextFileSource.java* class.
> >
> > Best wishes,
> > Mirko
> >
> >
> > --
> >
> > Dr. rer. nat. Mirko Kämpf
> > Müchelner Str. 23
> > 06259 Frankleben
> >
>
Re: PR Ready for review
Posted by Zoi Kaoudi <zk...@yahoo.gr.INVALID>.
I think Mirko's PR was in branch rel/0.7.1 and the rest of the PRs are in the main branch. Maybe there are no workflows in rel/0.7.1 branch. BTW, I don't remember what we agreed for the developing branch, is it the main one?
We need @Glaucia to clarify things ;)
Best
--
Zoi
Στις Τρίτη 10 Οκτωβρίου 2023 στις 02:38:24 μ.μ. CEST, ο χρήστης Kaustubh Beedkar <kb...@gmail.com> έγραψε:
I just merged the PR. Thanks, @Mirko for the contribution.
@Zoi that is strange. could it be that the workflow was not triggered?
Best,
Kaustubh
On Tue, Oct 10, 2023 at 5:32 PM Zoi Kaoudi <zk...@yahoo.gr.invalid> wrote:
> Thanks a lot Mirko. The PR looks good to me.
> However, I do not see the usual checks that we have for PRs.@Glaucia: any
> idea why is that?
> Best
> --
> Zoi
>
> Στις Τρίτη 10 Οκτωβρίου 2023 στις 01:52:00 μ.μ. CEST, ο χρήστης Mirko
> Kämpf <mi...@gmail.com> έγραψε:
>
> Dear Apache Wayang community,
>
> Here is a pull request which brings the ability to read remote files from a
> webserver via https protocol.
>
> https://github.com/apache/incubator-wayang/pull/348
>
> I added a test new class, a test data file, and modified the
> *JavaTextFileSource.java* class.
>
> Best wishes,
> Mirko
>
>
> --
>
> Dr. rer. nat. Mirko Kämpf
> Müchelner Str. 23
> 06259 Frankleben
>
Re: PR Ready for review
Posted by Kaustubh Beedkar <kb...@gmail.com>.
I just merged the PR. Thanks, @Mirko for the contribution.
@Zoi that is strange. could it be that the workflow was not triggered?
Best,
Kaustubh
On Tue, Oct 10, 2023 at 5:32 PM Zoi Kaoudi <zk...@yahoo.gr.invalid> wrote:
> Thanks a lot Mirko. The PR looks good to me.
> However, I do not see the usual checks that we have for PRs.@Glaucia: any
> idea why is that?
> Best
> --
> Zoi
>
> Στις Τρίτη 10 Οκτωβρίου 2023 στις 01:52:00 μ.μ. CEST, ο χρήστης Mirko
> Kämpf <mi...@gmail.com> έγραψε:
>
> Dear Apache Wayang community,
>
> Here is a pull request which brings the ability to read remote files from a
> webserver via https protocol.
>
> https://github.com/apache/incubator-wayang/pull/348
>
> I added a test new class, a test data file, and modified the
> *JavaTextFileSource.java* class.
>
> Best wishes,
> Mirko
>
>
> --
>
> Dr. rer. nat. Mirko Kämpf
> Müchelner Str. 23
> 06259 Frankleben
>
Re: PR Ready for review
Posted by Zoi Kaoudi <zk...@yahoo.gr.INVALID>.
Thanks a lot Mirko. The PR looks good to me.
However, I do not see the usual checks that we have for PRs.@Glaucia: any idea why is that?
Best
--
Zoi
Στις Τρίτη 10 Οκτωβρίου 2023 στις 01:52:00 μ.μ. CEST, ο χρήστης Mirko Kämpf <mi...@gmail.com> έγραψε:
Dear Apache Wayang community,
Here is a pull request which brings the ability to read remote files from a
webserver via https protocol.
https://github.com/apache/incubator-wayang/pull/348
I added a test new class, a test data file, and modified the
*JavaTextFileSource.java* class.
Best wishes,
Mirko
--
Dr. rer. nat. Mirko Kämpf
Müchelner Str. 23
06259 Frankleben