You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/07/17 12:24:09 UTC

Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/
-----------------------------------------------------------

Review request for cloudstack and Girish Shilamkar.


Bugs: CLOUDSTACK-7013
    https://issues.apache.org/jira/browse/CLOUDSTACK-7013


Repository: cloudstack-git


Description
-------

Corrected typo. cls.append to cls._cleanup.append


Diffs
-----

  test/integration/component/test_add_remove_network.py dbba59b 

Diff: https://reviews.apache.org/r/23611/diff/


Testing
-------

Yes.

Log:

Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 1 test in 172.776s

OK


Thanks,

Ashutosh Kelkar


Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/#review48900
-----------------------------------------------------------


Commit 6b66fe92ca89633ec64397cedb0d1572d0089c93 in cloudstack's branch refs/heads/4.4 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=6b66fe9 ]

CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

(cherry picked from commit f99a96f38a1f2433cb01bd7af25890789716e070)


- ASF Subversion and Git Services


On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23611/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7013
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7013
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Corrected typo. cls.append to cls._cleanup.append
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py dbba59b 
> 
> Diff: https://reviews.apache.org/r/23611/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> 
> Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 172.776s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/#review48000
-----------------------------------------------------------


Commit f99a96f38a1f2433cb01bd7af25890789716e070 in cloudstack's branch refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f99a96f ]

CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py


- ASF Subversion and Git Services


On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23611/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7013
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7013
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Corrected typo. cls.append to cls._cleanup.append
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py dbba59b 
> 
> Diff: https://reviews.apache.org/r/23611/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> 
> Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 172.776s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>


Re: Review Request 23611: CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23611/#review48001
-----------------------------------------------------------


Commit 332191b1bf2935bcad4c05a9fd61d0ebc30f035b in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=332191b ]

CLOUDSTACK-7013: Fixing test script issue in test_add_remove_network.py


- ASF Subversion and Git Services


On July 17, 2014, 10:24 a.m., Ashutosh Kelkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23611/
> -----------------------------------------------------------
> 
> (Updated July 17, 2014, 10:24 a.m.)
> 
> 
> Review request for cloudstack and Girish Shilamkar.
> 
> 
> Bugs: CLOUDSTACK-7013
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7013
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Corrected typo. cls.append to cls._cleanup.append
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_add_remove_network.py dbba59b 
> 
> Diff: https://reviews.apache.org/r/23611/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> Log:
> 
> Try to remove nic from a vm providing wrong vm id to API ... === TestName: test_19_remove_nic_wrong_vm_id | Status : SUCCESS ===
> ok
> 
> ----------------------------------------------------------------------
> Ran 1 test in 172.776s
> 
> OK
> 
> 
> Thanks,
> 
> Ashutosh Kelkar
> 
>