You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/11 21:16:21 UTC

[GitHub] [pulsar] heesung-sn commented on a diff in pull request #16011: [improve][tests] improved flaky test runs

heesung-sn commented on code in PR #16011:
URL: https://github.com/apache/pulsar/pull/16011#discussion_r895068717


##########
tests/integration/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java:
##########
@@ -1584,7 +1584,7 @@ private void publishAndConsumeMessages(String inputTopic,
         }
 
         for (int i = 0; i < numMessages; i++) {
-            Message<byte[]> msg = consumer.receive(30, TimeUnit.SECONDS);
+            Message<byte[]> msg = consumer.receive();

Review Comment:
   Because the test env can be really hectic, I think we could see timeouts from time to time. If the response is really delayed, the test will eventually fail. So, yes, I think this will improve the test stability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org