You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avalon.apache.org by Peter Donald <do...@apache.org> on 2001/03/27 07:22:26 UTC
Re: cvs commit:
jakarta-avalon-logkit/src/java/org/apache/logLogEngine.java
LogKit.java Logger.java
At 09:14 26/3/01 -0800, Jon Stevens wrote:
>on 3/26/01 8:20 PM, "donaldp@apache.org" <do...@apache.org> wrote:
>
>> - public Logger( final Category category )
>> + public Logger( final LogEngine engine, final Category category )
>
>Can I kill someone?
>
>API CHANGES NEED TO BE DEPRECATED!!!!!!!!!!!!!!!!!!!!
It is highly unlikely that anyone was using that "API". In reality the
methods should have been package/protected access anyway - not sure why
they were public. If someone does have an issue with there is an ugly hack
workaround but I don't see it is likely.
If every "API change" was deprecated there would be mountains of archaic
code in certain projects (ant and avalon being two candidates).
Cheers,
Pete
*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof." |
| - John Kenneth Galbraith |
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: cvs
commit:jakarta-avalon-logkit/src/java/org/apache/logLogEngine.java
LogKit.javaLogger.java
Posted by Jon Stevens <jo...@latchkey.com>.
on 3/27/01 1:44 AM, "Peter Donald" <do...@apache.org> wrote:
> (a) I was under impression velocity was moving to log4j
Myself and Geir and Jason added support for the ability to plug in any
logging tool via a simple interface. Both LogKit and Log4J are both fully
supported.
> (b) they never directly called the constructor
Ok. That is something that I wanted you to confirm. However, how do you know
what other people's software is calling?
> (c) if it had of broken them it would have taken a simple note to fix it
> rather than screaming "bloody murder"
The point being that Sam has been quietly screaming bloody murder for the
last 3-4 months now and it still doesn't seem to be getting into anyone's
head. I'm not afraid to scream a bit louder. Eh? :-)
-jon
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: cvs
commit:jakarta-avalon-logkit/src/java/org/apache/logLogEngine.java
LogKit.javaLogger.java
Posted by Peter Donald <do...@apache.org>.
At 11:53 26/3/01 -0800, Jon Stevens wrote:
>Ok, so if you object to it so much, how come you went back and fixed it
>after I complained?
I don't object to it but I am not going to put pointless effort into
maintaining something that no one wants/needs/uses. The only it was put in
was because presumably you have a problem which requires it.
>Also, given that Velocity is known to use logkit, how about you take the
>time to make sure that Velocity still builds correctly against your changes?
Well
(a) I was under impression velocity was moving to log4j
(b) they never directly called the constructor
(c) if it had of broken them it would have taken a simple note to fix it
rather than screaming "bloody murder"
Cheers,
Pete
*-----------------------------------------------------*
| "Faced with the choice between changing one's mind, |
| and proving that there is no need to do so - almost |
| everyone gets busy on the proof." |
| - John Kenneth Galbraith |
*-----------------------------------------------------*
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org
Re: cvs commit:
jakarta-avalon-logkit/src/java/org/apache/logLogEngine.java LogKit.java
Logger.java
Posted by Jon Stevens <jo...@latchkey.com>.
on 3/26/01 9:22 PM, "Peter Donald" <do...@apache.org> wrote:
> It is highly unlikely that anyone was using that "API". In reality the
> methods should have been package/protected access anyway - not sure why
> they were public. If someone does have an issue with there is an ugly hack
> workaround but I don't see it is likely.
>
> If every "API change" was deprecated there would be mountains of archaic
> code in certain projects (ant and avalon being two candidates).
Ok, so if you object to it so much, how come you went back and fixed it
after I complained?
Also, given that Velocity is known to use logkit, how about you take the
time to make sure that Velocity still builds correctly against your changes?
thanks,
-jon
--
If you come from a Perl or PHP background, JSP is a way to take
your pain to new levels. --Anonymous
<http://jakarta.apache.org/velocity/ymtd/ymtd.html>
---------------------------------------------------------------------
To unsubscribe, e-mail: avalon-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: avalon-dev-help@jakarta.apache.org