[GitHub] bosschaert commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

[GitBox <gi...@apache.org>]

bosschaert commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions
URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-437375351
 
 
   Hi @simonetripodi @cziegeler I was playing with the new plugin a little and found out that the same code that is checked in can also handle the following maven configuration:
   
   ```
               <scan>
                 <includes>**/*.json</includes>
                 <includeTasks>api-regions-dependencies</includeTasks>
                 <!-- taskConfiguration is a String, Properties map -->
                 <taskConfiguration>
                   <!-- each key represents an AnalyserTask ID -->
                   <api-regions-dependencies>
                     <!-- can use keyname-textvalue syntax too -->
                     <exporting-apis>my-global</exporting-apis>
                     <hiding-apis>my-deprecated</hiding-apis>
                   </api-regions-dependencies>
                 </taskConfiguration>
               </scan>
   ```
   So we can also use named keys for the task configuration. I think this is a little bit nicer since we already use named keys to address the task and it's more compact.
   
   As I mentioned - no need to change the code for this; it already works. It's just a matter of documenting/style. I'll update  https://github.com/apache/sling-slingfeature-maven-plugin/README.md with some documentation about this goal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services