You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/08/10 16:47:47 UTC

[GitHub] incubator-pirk pull request #52: Tighten declared parameter types to avoid c...

GitHub user tellison opened a pull request:

    https://github.com/apache/incubator-pirk/pull/52

    Tighten declared parameter types to avoid casting.

     - Change formal params in #embeddedSelectorToPartitions and
    #getEmbeddedSelector from Object to more specific String/DataPartitioner
    and tidy-up calling code that was casting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tellison/incubator-pirk QUtils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #52
    
----
commit 3b804f240ab9e5af0dff88f41f4b305c1782f08c
Author: Tim Ellison <t....@gmail.com>
Date:   2016-08-10T16:43:12Z

    Tighten declared parameter types to avoid casing.
    
     - Change formal params in #embeddedSelectorToPartitions and
    #getEmbeddedSelector from Object to more specific String/DataPartitioner
    and tidy-up calling code that was casting.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #52: Tighten declared parameter types to avoid casting.

Posted by ellisonanne <gi...@git.apache.org>.

Github user ellisonanne commented on the issue:

    https://github.com/apache/incubator-pirk/pull/52
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk pull request #52: Tighten declared parameter types to avoid c...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-pirk/pull/52


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-pirk issue #52: Tighten declared parameter types to avoid casting.

Posted by smarthi <gi...@git.apache.org>.

Github user smarthi commented on the issue:

    https://github.com/apache/incubator-pirk/pull/52
  
    +1 lgtm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---