[GitHub] [solr] uschindler commented on a diff in pull request #1320: SOLR-16641 - Generate gradle.properties from gradlew

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on code in PR #1320:
URL: https://github.com/apache/solr/pull/1320#discussion_r1093064393


##########
gradle/generation/local-settings.gradle:
##########
@@ -45,83 +45,4 @@ configure(rootProject) {
       }
     }
   }
-

Review Comment:
   Please keep the "deprecated" localSettings task fora while as all jenkins/github jobs execute them. We can remove it later, but for now add a "fake" task for compatibility.



##########
gradle.properties.template:
##########
@@ -0,0 +1,43 @@
+# See gradlew :helpLocalSettings for more information on configuring this file.
+systemProp.file.encoding=UTF-8
+
+# Set up gradle JVM defaults.
+#
+# We also open up internal compiler modules for spotless/ google java format.
+org.gradle.jvmargs=-Xmx1g -XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 \
+ --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
+ --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED
+
+# Run at normal priority, in parallel
+org.gradle.parallel=true
+org.gradle.priority=normal
+
+# This setting enables local task output caches. This will speed up
+# your local builds in most cases but will also consume disk space in your
+# gradle home. See SOLR-15603 for details.
+# org.gradle.caching=true
+
+# Silence gradle warnings. We'll deal with them when we upgrade the wrapper.
+org.gradle.warning.mode=none
+
+# You may disable the background daemon if it consumes too much memory.
+org.gradle.daemon=true
+# timeout after 15 mins of inactivity.
+org.gradle.daemon.idletimeout=900000
+
+# Maximum number of parallel gradle workers.
+org.gradle.workers.max=8
+
+# Maximum number of test JVMs forked per test task.
+tests.jvms=8

Review Comment:
   Please use a low value like "2" as default (also for max workers). If I start gradle on my laptop i dont want the machine to crush.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org