[GitHub] [kafka] C0urante commented on a diff in pull request #12191: KAFKA-12657: Increase timeouts in Connect integration tests

[GitBox <gi...@apache.org>]

C0urante commented on code in PR #12191:
URL: https://github.com/apache/kafka/pull/12191#discussion_r880460302


##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnectClusterAssertions.java:
##########
@@ -44,9 +44,9 @@
 public class EmbeddedConnectClusterAssertions {
 
     private static final Logger log = LoggerFactory.getLogger(EmbeddedConnectClusterAssertions.class);
-    public static final long WORKER_SETUP_DURATION_MS = TimeUnit.SECONDS.toMillis(60);
+    public static final long WORKER_SETUP_DURATION_MS = TimeUnit.MINUTES.toMillis(5);

Review Comment:
   I'm worried that with incremental increases, even if things are sufficient for now, they may become insufficient again in the near future. Given how infrequently changes that affect worker startup are (which might lead to this timeout elapsing before a true test failure is surfaced) and the number of moving parts that have to get initialized for an embedded Connect cluster to get off the ground, it seems worth the tradeoff to make the timeout high here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org