[GitHub] [pulsar] eolivelli commented on a change in pull request #14440: fix: add timeout when delete topic

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #14440:
URL: https://github.com/apache/pulsar/pull/14440#discussion_r814532487



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -309,7 +309,8 @@ protected void internalDeleteTopicForcefully(boolean authoritative, boolean dele
         validateNamespaceOperation(topicName.getNamespaceObject(), NamespaceOperation.DELETE_TOPIC);
 
         try {
-            pulsar().getBrokerService().deleteTopic(topicName.toString(), true, deleteSchema).get();

Review comment:
       good idea @michaeljmarshall 
   
   @leizhiyuan if you want to fix this specific point the best way it not to add a timeout but not perform blocking calls as described here
   https://github.com/apache/pulsar/issues/14438#issuecomment-1050601917




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org