You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/02 17:00:44 UTC
svn commit: r1887093 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java
Author: tilman
Date: Tue Mar 2 17:00:44 2021
New Revision: 1887093
URL: http://svn.apache.org/viewvc?rev=1887093&view=rev
Log:
PDFBOX-4892: avoid potential memory leak, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java?rev=1887093&r1=1887092&r2=1887093&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/Loader.java Tue Mar 2 17:00:44 2021
@@ -71,8 +71,11 @@ public class Loader
*/
public static FDFDocument loadFDF(File file) throws IOException
{
- FDFParser parser = new FDFParser(new RandomAccessReadBufferedFile(file));
- return parser.parse();
+ try (RandomAccessRead readBuffer = new RandomAccessReadBufferedFile(file))
+ {
+ FDFParser parser = new FDFParser(readBuffer);
+ return parser.parse();
+ }
}
/**
@@ -86,8 +89,11 @@ public class Loader
*/
public static FDFDocument loadFDF(InputStream input) throws IOException
{
- FDFParser parser = new FDFParser(new RandomAccessReadBuffer(input));
- return parser.parse();
+ try (RandomAccessRead readBuffer = new RandomAccessReadBuffer(input))
+ {
+ FDFParser parser = new FDFParser(readBuffer);
+ return parser.parse();
+ }
}
/**