You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/01 00:05:13 UTC
[GitHub] [tvm] mherkazandjian opened a new pull request #7780: [CI] add the --net=host cmd line arg to the docker/bash.it script
mherkazandjian opened a new pull request #7780:
URL: https://github.com/apache/tvm/pull/7780
introduce the ``--net=host`` command line argument to the ``docker/bash.sh``. This is already available
for https://github.com/apache/tvm/blob/main/docker/build.sh#L71
Without this change it is not possible to have an arbitrary command executed through ``docker?bash.sh``
and have interactivity enabled since the following section https://github.com/apache/tvm/blob/main/docker/bash.sh#L52
imposes running ``bash`` and overwrites the value of ``COMMAND``.
With this change, one would be able to have bridged host networking in addition to executing an
arbitrary command.
on another note, i think it would be quite helpful to check if e.g ``CI_DOCKER_EXTRA_PARAMS`` is defined
as an environment variable, then ``docker/bash.sh`` would append variables, so the calling sequence would be:
````bash
export CI_DOCKER_EXTRA_PARAMS="--net=host -v foo:bar .... some_other_docker_flags"
./docker/bash.sh -i tvm.ci_cpu SOME_COMMANDS_HERE
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mherkazandjian commented on pull request #7780: [CI] add the --net=host cmd line arg to the docker/bash.it script
Posted by GitBox <gi...@apache.org>.
mherkazandjian commented on pull request #7780:
URL: https://github.com/apache/tvm/pull/7780#issuecomment-812654650
@tqchen i can spend some time implementing the option that i described:
````
on another note, i think it would be quite helpful to check if e.g CI_DOCKER_EXTRA_PARAMS is defined
as an environment variable, then docker/bash.sh would append variables, so the calling sequence would be:
````
do you think this would be merged or not worth implementing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7780: [CI] add the --net=host cmd line arg to the docker/bash.it script
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7780:
URL: https://github.com/apache/tvm/pull/7780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7780: [CI] add the --net=host cmd line arg to the docker/bash.it script
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7780:
URL: https://github.com/apache/tvm/pull/7780#issuecomment-812554540
Thank you @mherkazandjian !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org