You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/20 01:24:13 UTC

[GitHub] [pulsar] mattisonchao commented on a diff in pull request #17163: [fix][broker] Avoid messages being repeatedly replayed with SHARED subscriptions (streaming dispatcher)

mattisonchao commented on code in PR #17163:
URL: https://github.com/apache/pulsar/pull/17163#discussion_r950629777


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentStreamingDispatcherMultipleConsumers.java:
##########
@@ -155,6 +155,11 @@ protected void cancelPendingRead() {
 
     @Override
     public synchronized void readMoreEntries() {
+        if (sendInProgress) {

Review Comment:
   Hi @eolivelli 
   Can you clarify this problem?
   It looks like this logic already exists for `PersistentDispatcherMultipleConsumers`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org