You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by wwken <gi...@git.apache.org> on 2015/07/01 22:39:15 UTC

[GitHub] pig pull request: Fixed the 'new line' character inside double-quo...

GitHub user wwken opened a pull request:

    https://github.com/apache/pig/pull/20

    Fixed the 'new line' character inside double-quote causing the csv pa…

    A new line character should be allowed inside a double quote as a valid csv document.  For example, the following csv document should be treated as a SINGLE valid csv data
    
    Iphone,"{ ItemName : Cheez-It
    21 Ounce}",
    
    However, the current implementation of the getNext() inside org.apache.pig.piggybank.storage.CSVLoader class fails to take care of this case and it sees two lines of data while in fact it should be treated as single line of data.
    
    This pull request fixes the above issue.
    
    (Note: here is a linke to validate whether a csv document:  http://csvlint.io/)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wwken/pig trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/pig/pull/20.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20
    
----
commit 9b3d1eeb45d58bd3543acf50d6252a28ee60d0f6
Author: Ken W <ke...@qualia-media.com>
Date:   2015-07-01T20:30:25Z

    Fixed the 'new line' character inside double-quote causing the csv parsing failure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---