You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Masatake Iwasaki (Jira)" <ji...@apache.org> on 2020/07/21 12:19:00 UTC

[jira] [Updated] (YARN-10358) Fix findbugs warnings in hadoop-yarn-project on branch-2.10

     [ https://issues.apache.org/jira/browse/YARN-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Masatake Iwasaki updated YARN-10358:
------------------------------------
    Description: 
{noformat}
$ find . -name findbugsXml.xml | xargs -n 1 /opt/findbugs-3.0.1/bin/convertXmlToText -longBugCodes
M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.state.StateMachineFactory.generateStateGraph(String) makes inefficient use of keySet iterator instead of entrySet iterator  At StateMachineFactory.java:[line 505]
M P BX_UNBOXING_IMMEDIATELY_REBOXED Bx: Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnRWHelper.readResultsWithTimestamps(Result, byte[], byte[], KeyConverter, ValueConverter, boolean)  At ColumnRWHelper.java:[line 335]
M D UC_USELESS_OBJECT UC: Useless object stored in variable removedNullContainers of method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)  At NodeStatusUpdaterImpl.java:[line 664]
M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache() makes inefficient use of keySet iterator instead of entrySet iterator  At NodeStatusUpdaterImpl.java:[line 741]
M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus() makes inefficient use of keySet iterator instead of entrySet iterator  At ContainerLocalizer.java:[line 359]
M V MS_MUTABLE_COLLECTION_PKGPROTECT MS: org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics is a mutable collection which should be package protected  At ContainerMetrics.java:[line 134]
{noformat}


> Fix findbugs warnings in hadoop-yarn-project on branch-2.10
> -----------------------------------------------------------
>
>                 Key: YARN-10358
>                 URL: https://issues.apache.org/jira/browse/YARN-10358
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.10.0
>            Reporter: Masatake Iwasaki
>            Assignee: Masatake Iwasaki
>            Priority: Minor
>
> {noformat}
> $ find . -name findbugsXml.xml | xargs -n 1 /opt/findbugs-3.0.1/bin/convertXmlToText -longBugCodes
> M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.state.StateMachineFactory.generateStateGraph(String) makes inefficient use of keySet iterator instead of entrySet iterator  At StateMachineFactory.java:[line 505]
> M P BX_UNBOXING_IMMEDIATELY_REBOXED Bx: Boxed value is unboxed and then immediately reboxed in org.apache.hadoop.yarn.server.timelineservice.storage.common.ColumnRWHelper.readResultsWithTimestamps(Result, byte[], byte[], KeyConverter, ValueConverter, boolean)  At ColumnRWHelper.java:[line 335]
> M D UC_USELESS_OBJECT UC: Useless object stored in variable removedNullContainers of method org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeOrTrackCompletedContainersFromContext(List)  At NodeStatusUpdaterImpl.java:[line 664]
> M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.server.nodemanager.NodeStatusUpdaterImpl.removeVeryOldStoppedContainersFromCache() makes inefficient use of keySet iterator instead of entrySet iterator  At NodeStatusUpdaterImpl.java:[line 741]
> M P WMI_WRONG_MAP_ITERATOR WMI: org.apache.hadoop.yarn.server.nodemanager.containermanager.localizer.ContainerLocalizer.createStatus() makes inefficient use of keySet iterator instead of entrySet iterator  At ContainerLocalizer.java:[line 359]
> M V MS_MUTABLE_COLLECTION_PKGPROTECT MS: org.apache.hadoop.yarn.server.nodemanager.containermanager.monitor.ContainerMetrics.usageMetrics is a mutable collection which should be package protected  At ContainerMetrics.java:[line 134]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org