You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/06/28 07:24:52 UTC

[GitHub] [ozone] jojochuang commented on pull request #2372: HDDS-5383. Eliminate expensive string creation in debug log messages

jojochuang commented on pull request #2372:
URL: https://github.com/apache/ozone/pull/2372#issuecomment-869428726


   Can you also fix these two as well?
   https://github.com/apache/ozone/blob/2254abfa4d8ee3fda24c3d7215b0ddca61632fec/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMSecurityProtocolFailoverProxyProvider.java#L213
   https://github.com/apache/ozone/blob/2254abfa4d8ee3fda24c3d7215b0ddca61632fec/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/proxy/SCMBlockLocationFailoverProxyProvider.java#L189
   
   given the complexity of the debug message, I suggest to wrap them with LOG.isDebugEnabled() too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org