[jira] [Commented] (TINKERPOP-2015) Allow users to configure the WebSocket connections

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16608448#comment-16608448 ] 

ASF GitHub Bot commented on TINKERPOP-2015:
-------------------------------------------

GitHub user FlorianHockmann opened a pull request:

    https://github.com/apache/tinkerpop/pull/928

    TINKERPOP-2015 Expose WebSocket configuration in Gremlin.Net driver

    https://issues.apache.org/jira/browse/TINKERPOP-2015
    
    Users can now provide a delegate to the Gremlin.Net driver that will be used to configure WebSocket connections. Using a delegate for this has the advantage that it's extensible as the options available via [`ClientWebSocketOptions`](https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions) change between different .NET implementations, e.g., as mentioned in the ticket, a `RemoteCertificateValidationCallback` was added with .NET Core 2.1.
    
    When #903 is merged first, then we need to add this new option also to the docs when merging this into `master` as #903 adds descriptions for the config options to the docs.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2015

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #928
    
----
commit 828b0503e4d0f0a9b21f89158bbef31de20ffa3a
Author: Florian Hockmann <fh...@...>
Date:   2018-09-09T12:49:03Z

    Expose WebSocket configuration TINKERPOP-2015
    
    Users can now provide a delegate to the Gremlin.Net driver that will be
    used to configure WebSocket connections.

----


> Allow users to configure the WebSocket connections
> --------------------------------------------------
>
>                 Key: TINKERPOP-2015
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2015
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet
>    Affects Versions: 3.3.3, 3.2.9
>            Reporter: Florian Hockmann
>            Assignee: Florian Hockmann
>            Priority: Major
>
> Gremlin.Net currently just creates instances of the {{ClientWebSocket}} class with default options. That is probably appropriate for most users but it makes it impossible to change the config and use certain features like client certificates or proxy settings.
> We could simply allow users to provide a [{{ClientWebSocketOptions}}|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions] object. Since it's part of .NET Standard (and not a 3rd party library) it shouldn't be a problem to expose this type. This would also have the nice advantage that users could immediately use new options like the {{[RemoteCertificateValidationCallback|https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions.remotecertificatevalidationcallback]}} that was just added in .NET Core 2.1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)