[GitHub] [pinot] agavra commented on a diff in pull request #9600: [PROTOTYPE] polymorphism in function calls

[GitBox <gi...@apache.org>]

agavra commented on code in PR #9600:
URL: https://github.com/apache/pinot/pull/9600#discussion_r997256909


##########
pinot-common/src/main/java/org/apache/pinot/common/function/FunctionRegistry.java:
##########
@@ -49,11 +54,53 @@ private FunctionRegistry() {
 
   // TODO: consolidate the following 2
   // This FUNCTION_INFO_MAP is used by Pinot server to look up function by # of arguments
-  private static final Map<String, Map<Integer, FunctionInfo>> FUNCTION_INFO_MAP = new HashMap<>();
+  private static final Map<String, Map<List<Class<?>>, FunctionInfo>> FUNCTION_INFO_MAP = new HashMap<>();
   // This FUNCTION_MAP is used by Calcite function catalog tolook up function by function signature.
   private static final NameMultimap<Function> FUNCTION_MAP = new NameMultimap<>();
 
+  // checks casts between primitives

Review Comment:
   In my latest approach I decided to leverage Calcite - it wasn't too hard and that way we'll have consistency between v1 and v2. See https://github.com/apache/calcite/blob/2c30a56158cdd351d35725006bc1f76bb6aac75b/core/src/main/java/org/apache/calcite/sql/SqlUtil.java#L635-L684



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org