[jira] Commented: (HADOOP-914) Replace use of UTF8 in ObjectWritable

["Andrzej Bialecki (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12466324 ] 

Andrzej Bialecki  commented on HADOOP-914:
------------------------------------------

The patch looks quite nice, and it would be definitely useful to have this functionality in some situations. However, somehow I don't think we need as many as three similar implementations of this type of containers ... We have ObjectWritable, GenericWritable and WrappingWritable - it's mightily confusing which one should be used in user applications ...

I'm not sure if we shouldn't first try to find a minimum common set of functionality to be implemented in a single base wrapper class, and then extend it for different uses - I think that if we commit this patch there will be a mess ...

> Replace use of UTF8 in ObjectWritable
> -------------------------------------
>
>                 Key: HADOOP-914
>                 URL: https://issues.apache.org/jira/browse/HADOOP-914
>             Project: Hadoop
>          Issue Type: Improvement
>    Affects Versions: 0.10.1
>            Reporter: Sami Siren
>         Attachments: HADOOP-914.patch
>
>
> - Replace use of UTF8 with Text
> - Make format a little less verbose, before ObjectWritable containing Text "text" would be stored like:
>   <UTF8:org.apache.hadoop.io.Text><UTF8:org.apache.hadoop.io.Text><Text:text>
>   now it is stored as
>   <Text:org.apache.hadoop.io.Text><Text:text>
> -As changes are incompatible they are introduced in a new class 'WrappingWritable', ObjectWritable is deprecated
> -Add junit test

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira