You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2020/04/02 02:39:03 UTC

[kudu-CR] ranger: direct client logs to a log file

Hello Kudu Jenkins, Adar Dembo, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15628

to look at the new patch set (#2).

Change subject: ranger: direct client logs to a log file
......................................................................

ranger: direct client logs to a log file

This patch enables us to direct Java subprocess logs to a rolling file
with the new "-r" option. The subprocess will use the KUDU_LOG_DIR and
KUDU_LOG_NAME system properties to output logs as appropriate.

Since, in production, we expect users to prefer these logs over stdout,
this also makes logging to stdout optional with the new "-s" option.
Logging to stdout is enabled in subprocess_proxy-test and
subprocess_server-test since it's useful to view the subprocess logs
in-line with test output.

Here's what's in a Ranger-configured Kudu master's log directory (I
lowered the rolling size threshold for the sake of generating a new roll
quickly):
 kudu-master.INFO -> kudu-master.awong-MBP16-21621.local.awong.log.INFO.20200401-193144.59433
 kudu-master.WARNING -> kudu-master.awong-MBP16-21621.local.awong.log.WARNING.20200401-193151.59433
 kudu-master.awong-MBP16-21621.local.awong.diagnostics.20200401-193145.0.59433
 kudu-master.awong-MBP16-21621.local.awong.log.INFO.20200401-193144.59433
 kudu-master.awong-MBP16-21621.local.awong.log.WARNING.20200401-193151.59433
 kudu-ranger-client.awong-MBP16-21621.local.20200401-193145.log.gz
 kudu-ranger-client.awong-MBP16-21621.local.log

Change-Id: I7efa631832c219fce214304538e6ab6442062752
---
M java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessConfiguration.java
M java/kudu-subprocess/src/main/resources/log4j2.properties
M src/kudu/ranger/ranger_client.cc
M src/kudu/subprocess/subprocess_proxy-test.cc
M src/kudu/subprocess/subprocess_server-test.cc
5 files changed, 108 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/15628/2
-- 
To view, visit http://gerrit.cloudera.org:8080/15628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7efa631832c219fce214304538e6ab6442062752
Gerrit-Change-Number: 15628
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)