[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21114: [FLINK-29622][runtime][security] Start kerberos delegation token prov…

[GitBox <gi...@apache.org>]

gaborgsomogyi commented on code in PR #21114:
URL: https://github.com/apache/flink/pull/21114#discussion_r999540330


##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/token/KerberosDelegationTokenManagerFactory.java:
##########
@@ -40,12 +41,21 @@ public static DelegationTokenManager create(
             ClassLoader classLoader,
             Configuration configuration,
             @Nullable ScheduledExecutor scheduledExecutor,
-            @Nullable ExecutorService ioExecutor) {
+            @Nullable ExecutorService ioExecutor)
+            throws IOException {
 
         if (configuration.getBoolean(SecurityOptions.KERBEROS_FETCH_DELEGATION_TOKEN)) {
             if (HadoopDependency.isHadoopCommonOnClasspath(classLoader)) {
-                return new KerberosDelegationTokenManager(
-                        configuration, scheduledExecutor, ioExecutor);
+                KerberosLoginProvider kerberosLoginProvider =
+                        new KerberosLoginProvider(configuration);
+                if (kerberosLoginProvider.isLoginPossible()) {

Review Comment:
   Having a static function which is hardly testable would be more strange. From perf perspective this runs once per cluster start.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org