[GitHub] [airflow] aneesh-joseph commented on a change in pull request #8777: Add Production Helm chart support

[GitBox <gi...@apache.org>]

aneesh-joseph commented on a change in pull request #8777:
URL: https://github.com/apache/airflow/pull/8777#discussion_r422158586



##########
File path: chart/templates/configmap.yaml
##########
@@ -0,0 +1,108 @@
+################################
+## Airflow ConfigMap
+#################################
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: {{ template "airflow_config" . }}
+  labels:
+    tier: airflow
+    component: config
+    release: {{ .Release.Name }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    heritage: {{ .Release.Service }}
+{{- with .Values.labels }}
+{{ toYaml . | indent 4 }}
+{{- end }}
+data:
+  # These are system-specified config overrides.
+  airflow.cfg: |

Review comment:
       can we expose the airflow.cfg via helm values 
   
   ```
   airflow_cfg:
     core:
       dags_folder: '$AIRFLOW_HOME/dags/repo'
       base_log_folder: '$AIRFLOW_HOME/logs'
       executor: KubernetesExecutor
       plugins_folder: '$AIRFLOW_HOME/plugins'
       sql_alchemy_conn:  $sql_alchemy_conn
       load_examples: false
       remote_logging:  false
       logging_level: WARN
       fab_logging_level: WARN
       store_serialized_dags: True
       min_serialized_dag_update_interval: 30
     scheduler:
       child_process_log_directory:  '$AIRFLOW_HOME/logs/scheduler'
       catchup_by_default: False
     webserver:
       rbac:  True
       update_fab_perms: True
       enable_proxy_fix: True
   ```
   
   
   and render it using something like the below one
   ```
     airflow.cfg: |-
       {{- $root := . -}}
       {{- range $airflow_config_header, $config_dict := .Values.airflow_cfg }}
       [{{ $airflow_config_header }}]
       {{- range $key, $val := $config_dict }}
       {{ $key }} = {{ $val }}
       {{- end}}
       {{- end}}
   ```
   
   to make it easier to change the airflow configuration




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org