You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/19 13:09:50 UTC

Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19624
    https://issues.apache.org/jira/browse/AMBARI-19624


Repository: ambari


Description
-------

Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 

Diff: https://reviews.apache.org/r/55718/diff/


Testing
-------

Manual


Thanks,

Padma Priya N


Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/#review162456
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Jan. 20, 2017, 5:55 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55718/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 5:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19624
>     https://issues.apache.org/jira/browse/AMBARI-19624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 4cc89ef 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 
> 
> Diff: https://reviews.apache.org/r/55718/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/#review162623
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 20, 2017, 5:55 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55718/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2017, 5:55 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19624
>     https://issues.apache.org/jira/browse/AMBARI-19624
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 4cc89ef 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf 
>   contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 
> 
> Diff: https://reviews.apache.org/r/55718/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

Posted by Padma Priya N <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55718/
-----------------------------------------------------------

(Updated Jan. 20, 2017, 5:55 a.m.)


Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19624
    https://issues.apache.org/jira/browse/AMBARI-19624


Repository: ambari


Description
-------

Added fields to support nofification message and upstream apps in the sla componenent and added the necessary mappings to handle the new fields while generating xml and importing xml.


Diffs (updated)
-----

  contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js 4cc89ef 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js 1929ddf 
  contrib/views/wfmanager/src/main/resources/ui/app/templates/components/sla-info.hbs 28bdf15 

Diff: https://reviews.apache.org/r/55718/diff/


Testing
-------

Manual


Thanks,

Padma Priya N