You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/01/07 21:57:59 UTC
[GitHub] [samza] cameronlee314 commented on a change in pull request #1243:
[DOCS] Updated contributors corner with PR guidelines.
cameronlee314 commented on a change in pull request #1243: [DOCS] Updated contributors corner with PR guidelines.
URL: https://github.com/apache/samza/pull/1243#discussion_r363970581
##########
File path: docs/contribute/contributors-corner.md
##########
@@ -96,7 +96,7 @@ If there is no [JIRA](https://issues.apache.org/jira/browse/SAMZA) ticket for yo
* Create a new branch in your repository and push your changes to that branch
* Make sure you have observed the recommendations in the [coding guide](/contribute/coding-guide.html) and [testing](/contribute/tests.html)
* [Open a Pull Request](https://help.github.com/articles/about-pull-requests/) against the “master” branch of apache/samza
- * Make sure that the Pull Request title is of the format "SAMZA-<JiraNumber> : <JiraTitle>"
+ * Make sure that the Pull Request title and description follows the guidelines in [SEP-25](https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines)
Review comment:
What do you think about copying the guidelines from SEP-25 into this page? It seems a little awkward to have these kinds of guidelines in a SEP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services