[GitHub] [superset] villebro commented on a change in pull request #17048: fix(elasticsearch): time_zone setting does not work for cast datetime expressions

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #17048:
URL: https://github.com/apache/superset/pull/17048#discussion_r747293931



##########
File path: superset/db_engine_specs/base.py
##########
@@ -686,13 +685,14 @@ def df_to_sql(
 
     @classmethod
     def convert_dttm(  # pylint: disable=unused-argument
-        cls, target_type: str, dttm: datetime,
+        cls, target_type: str, dttm: datetime, **kwargs: Any,

Review comment:
       Is there a reason this is `**kwargs: Any` and not `db_extra: Optional[Dict[str, Any]]` like has been done in `get_column_spec`? Unpacking into kwargs will make more difficult to add new parameters to this method going forward




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org