You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 11:23:07 UTC
[GitHub] [airflow] yogyang opened a new pull request #13537: fix lossing duration < 1 secs in tree
yogyang opened a new pull request #13537:
URL: https://github.com/apache/airflow/pull/13537
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
A minor fix for missing duration in tree view when task duration < 1 secs
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yogyang commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
yogyang commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r553278034
##########
File path: airflow/www/views.py
##########
@@ -1912,7 +1912,7 @@ def encode_ti(task_instance: Optional[models.TaskInstance]) -> Optional[List]:
# round to seconds to reduce payload size
task_instance_data[2] = int(task_instance.start_date.timestamp())
if task_instance.duration is not None:
- task_instance_data[3] = int(task_instance.duration)
+ task_instance_data[3] = float(task_instance.duration)
Review comment:
good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13537: fix lossing duration < 1 secs in tree
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-756057016
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yogyang commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
yogyang commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r554669436
##########
File path: airflow/www/views.py
##########
@@ -110,6 +110,15 @@
FILTER_STATUS_COOKIE = 'dag_status_filter'
+def get_truncate_task_duration(task_duration):
+ """
+ Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
+ otherwise we keep it as a float with 3dp(truncate)
+ """
+ duration = int(task_duration) if task_duration > 10.0 else math.trunc(task_duration * 1000) / 1000.0
+ return duration
Review comment:
I didn't use `round` just because the
truncate_task_duration(9.9996) = 10.0
truncate_task_duration(10.1231) = 10
I thought the truncate looks more straightforward when comparing to the database record.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #13537:
URL: https://github.com/apache/airflow/pull/13537
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13537: fix lossing duration < 1 secs in tree
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-756062904
Nice problem to have -- our tasks are now too quick :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-780608519
(Whoops sorry, my bad. I forgot about this PR entirely)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13537: fix lossing duration < 1 secs in tree
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r553277295
##########
File path: airflow/www/views.py
##########
@@ -1912,7 +1912,7 @@ def encode_ti(task_instance: Optional[models.TaskInstance]) -> Optional[List]:
# round to seconds to reduce payload size
task_instance_data[2] = int(task_instance.start_date.timestamp())
if task_instance.duration is not None:
- task_instance_data[3] = int(task_instance.duration)
+ task_instance_data[3] = float(task_instance.duration)
Review comment:
So, casting this to an int was an optimization for large/huge dags: https://github.com/apache/airflow/pull/7492, particularly https://github.com/apache/airflow/pull/7492#discussion_r384158218
So we might nee to make this smarter, say, and only say make it an int about 10 or 30s, and in other cases make it a float with 3dp (i.e. 0.123s, rather than the default which will be to 6 or 9 dp)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r553875066
##########
File path: airflow/www/views.py
##########
@@ -110,6 +110,15 @@
FILTER_STATUS_COOKIE = 'dag_status_filter'
+def get_truncate_task_duration(task_duration):
+ """
+ Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
+ otherwise we keep it as a float with 3dp(truncate)
+ """
+ duration = int(task_duration) if task_duration > 10.0 else math.trunc(task_duration * 1000) / 1000.0
+ return duration
Review comment:
```suggestion
def truncate_task_duration(task_duration):
"""
Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
otherwise we keep it as a float with 3dp
"""
return int(task_duration) if task_duration > 10.0 else round(task_duration, 3)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-758024363
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r554994249
##########
File path: airflow/www/views.py
##########
@@ -110,6 +110,15 @@
FILTER_STATUS_COOKIE = 'dag_status_filter'
+def get_truncate_task_duration(task_duration):
+ """
+ Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
+ otherwise we keep it as a float with 3dp(truncate)
+ """
+ duration = int(task_duration) if task_duration > 10.0 else math.trunc(task_duration * 1000) / 1000.0
+ return duration
Review comment:
I think for the one edge case of (`9.999` getting rounded to `10.0`) I'd rather easier to read code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-779964023
@yogyang could you rebase/resolve conflicts on this and we'll get it merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r553277295
##########
File path: airflow/www/views.py
##########
@@ -1912,7 +1912,7 @@ def encode_ti(task_instance: Optional[models.TaskInstance]) -> Optional[List]:
# round to seconds to reduce payload size
task_instance_data[2] = int(task_instance.start_date.timestamp())
if task_instance.duration is not None:
- task_instance_data[3] = int(task_instance.duration)
+ task_instance_data[3] = float(task_instance.duration)
Review comment:
So, casting this to an int was an optimization for large/huge dags: https://github.com/apache/airflow/pull/7492, particularly https://github.com/apache/airflow/pull/7492#discussion_r384158218
So we might nee to make this smarter, say, and only say make it an int above 10 or 30s, and in other cases make it a float with 3dp (i.e. 0.123s, rather than the default which will be to 6 or 9 dp)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#issuecomment-781457543
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r553875066
##########
File path: airflow/www/views.py
##########
@@ -110,6 +110,15 @@
FILTER_STATUS_COOKIE = 'dag_status_filter'
+def get_truncate_task_duration(task_duration):
+ """
+ Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
+ otherwise we keep it as a float with 3dp(truncate)
+ """
+ duration = int(task_duration) if task_duration > 10.0 else math.trunc(task_duration * 1000) / 1000.0
+ return duration
Review comment:
```suggestion
def truncate_task_duration(task_duration):
"""
Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
otherwise we keep it as a float with 3dp
"""
return int(task_duration) if task_duration > 10.0 else round(task_duration, 3)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yogyang commented on a change in pull request #13537: Durations less than 1 second are not visible in the TI tooltops
Posted by GitBox <gi...@apache.org>.
yogyang commented on a change in pull request #13537:
URL: https://github.com/apache/airflow/pull/13537#discussion_r554669436
##########
File path: airflow/www/views.py
##########
@@ -110,6 +110,15 @@
FILTER_STATUS_COOKIE = 'dag_status_filter'
+def get_truncate_task_duration(task_duration):
+ """
+ Cast task_duration to an int was for optimization for large/huge dags if task_duration > 10s
+ otherwise we keep it as a float with 3dp(truncate)
+ """
+ duration = int(task_duration) if task_duration > 10.0 else math.trunc(task_duration * 1000) / 1000.0
+ return duration
Review comment:
I didn't use `round` just because the
truncate_task_duration(9.9996) = 10.0
truncate_task_duration(10.1231) = 10
I thought the truncate looks more straightforward when comparing to the database record.
truncate_task_duration(9.9996) = 9.999
truncate_task_duration(10.1231) = 10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org