You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "li-keguo (via GitHub)" <gi...@apache.org> on 2023/05/03 08:51:51 UTC
[GitHub] [shenyu] li-keguo opened a new pull request, #4606: 【Type:feature 】The SPEL in the mock plugin is secure by default
li-keguo opened a new pull request, #4606:
URL: https://github.com/apache/shenyu/pull/4606
work list:
- [x] Use SimpleEvaluationContext as the default secure SPEL.
- [x] Provides a Standard Expression Generator, which is not loaded by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo merged pull request #4606: 【Type:feature 】The SPEL in the mock plugin is secure by default
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4606:
URL: https://github.com/apache/shenyu/pull/4606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo commented on pull request #4606: 【Type:feature 】The SPEL in the mock plugin is secure by default
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo commented on PR #4606:
URL: https://github.com/apache/shenyu/pull/4606#issuecomment-1532829723
> Well done! maybe standardSPELExpression can completely replace old one . I think we can remove old one. Have you ever try `MethodSecurityEvaluationContext`. are threre any differences between `StandardEvaluationContext` and `MethodSecurityEvaluationContext`?
The original has been replaced with a secure implementation. see https://docs.spring.io/spring-framework/docs/5.0.6.RELEASE/javadoc-api/org/springframework/expression/spel/support/SimpleEvaluationContext.html
StandardExpressionGenerator is not loaded by default and needs to be enabled by the user.
Without studying the MethodSecurityEvaluationContext, but only providing some clues, he came from spring-security.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4606: 【Type:feature 】The SPEL in the mock plugin is secure by default
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4606:
URL: https://github.com/apache/shenyu/pull/4606#issuecomment-1532812617
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4606](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (62b7808) into [master](https://app.codecov.io/gh/apache/shenyu/commit/ba6f3a341bb0bdf54cba5d5998a1b2f7889c63dd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ba6f3a3) will **decrease** coverage by `0.12%`.
> The diff coverage is `63.15%`.
```diff
@@ Coverage Diff @@
## master #4606 +/- ##
============================================
- Coverage 68.87% 68.76% -0.12%
- Complexity 7822 7826 +4
============================================
Files 1039 1041 +2
Lines 30034 30058 +24
Branches 2739 2736 -3
============================================
- Hits 20685 20668 -17
- Misses 7728 7765 +37
- Partials 1621 1625 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/shenyu/plugin/mock/MockPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay9Nb2NrUGx1Z2luLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../shenyu/plugin/mock/handler/MockPluginHandler.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay9oYW5kbGVyL01vY2tQbHVnaW5IYW5kbGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/shenyu/plugin/mock/util/MockUtil.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay91dGlsL01vY2tVdGlsLmphdmE=) | `78.00% <66.66%> (-1.60%)` | :arrow_down: |
| [...in/mock/generator/StandardExpressionGenerator.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay9nZW5lcmF0b3IvU3RhbmRhcmRFeHByZXNzaW9uR2VuZXJhdG9yLmphdmE=) | `85.71% <85.71%> (ø)` | |
| [...shenyu/plugin/mock/util/EvaluationContextUtil.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay91dGlsL0V2YWx1YXRpb25Db250ZXh0VXRpbC5qYXZh) | `89.47% <89.47%> (ø)` | |
| [...nyu/plugin/mock/generator/ExpressionGenerator.java](https://app.codecov.io/gh/apache/shenyu/pull/4606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vbW9jay9nZW5lcmF0b3IvRXhwcmVzc2lvbkdlbmVyYXRvci5qYXZh) | `100.00% <100.00%> (+10.00%)` | :arrow_up: |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4606/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] tian-pengfei commented on pull request #4606: 【Type:feature 】The SPEL in the mock plugin is secure by default
Posted by "tian-pengfei (via GitHub)" <gi...@apache.org>.
tian-pengfei commented on PR #4606:
URL: https://github.com/apache/shenyu/pull/4606#issuecomment-1532778322
Well done! maybe standardSPELExpression can completely replace old one . I think we can remove old one. Have you ever try different `MethodSecurityEvaluationContext`. are threre any differences between `StandardEvaluationContext` and `MethodSecurityEvaluationContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org