You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/22 14:44:55 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

tillrohrmann opened a new pull request #11866:
URL: https://github.com/apache/flink/pull/11866


   ## What is the purpose of the change
   
   This reverts commit 0cf9c2846ad1b293b91059d172dd68dd0ffbf803.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on issue #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11866:
URL: https://github.com/apache/flink/pull/11866#issuecomment-617839879


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 466d630eb61dbdee1d4846149e0c537f7e5a5cf7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on issue #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11866:
URL: https://github.com/apache/flink/pull/11866#issuecomment-617839879


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/161461323",
       "triggerID" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 466d630eb61dbdee1d4846149e0c537f7e5a5cf7 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161461323) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on issue #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11866:
URL: https://github.com/apache/flink/pull/11866#issuecomment-617826923


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 466d630eb61dbdee1d4846149e0c537f7e5a5cf7 (Wed Apr 22 14:50:20 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on issue #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11866:
URL: https://github.com/apache/flink/pull/11866#issuecomment-617839879


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/161461323",
       "triggerID" : "466d630eb61dbdee1d4846149e0c537f7e5a5cf7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 466d630eb61dbdee1d4846149e0c537f7e5a5cf7 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161461323) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on issue #11866: [BP-1.10] Revert "[FLINK-14499][metric] MetricRegistry#getMetricQueryServiceGatewayRpcAddress is Nonnull"

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11866:
URL: https://github.com/apache/flink/pull/11866#issuecomment-618303843


   Manually merged via 7a87aa415ef7a3cf6d2845e0e9fe5f4b8234503f


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org