You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/23 07:28:50 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #29339: [SPARK-32512][SQL] add alter table add/drop partition command for datasourcev2

cloud-fan commented on a change in pull request #29339:
URL: https://github.com/apache/spark/pull/29339#discussion_r510687944



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
##########
@@ -635,6 +636,16 @@ object CatalogTypes {
   lazy val emptyTablePartitionSpec: TablePartitionSpec = Map.empty[String, String]
 }
 
+trait PartitionSpec

Review comment:
       can we move them to `sql/catalyst/analysis/v2ResolutionPlans.scala`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org