[GitHub] [accumulo] dlmarion commented on a diff in pull request #2967: Update the new modify properties API to automatically retry on concurrent modification exception.

[GitBox <gi...@apache.org>]

dlmarion commented on code in PR #2967:
URL: https://github.com/apache/accumulo/pull/2967#discussion_r981420896


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1035,6 +1031,30 @@ public void modifyProperties(String tableName, final Consumer<Map<String,String>
     }
   }
 
+  @Override
+  public void modifyProperties(String tableName, final Consumer<Map<String,String>> mapMutator)

Review Comment:
   Does it make sense to return a Future<Void> here instead? That would allow the caller to potentially perform other logic before checking the result and the caller has to handle the exceptions when calling Future.get().



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org