You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/10/12 11:39:47 UTC

Review Request 62929: Added documentation to CSI-related source proto fields.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/
-----------------------------------------------------------

Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
-------

This commit adds clarifying documentation to CSI-related proto fields
in `Resource.DiskInfo.Source` which were introduced earlier.


Diffs
-----

  include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
  include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 


Diff: https://reviews.apache.org/r/62929/diff/1/


Testing
-------

NFC.


Thanks,

Benjamin Bannier

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by James DeFelice <ja...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187791
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 1347 (patched)
<https://reviews.apache.org/r/62929/#comment264835>

    CSI doesn't have "sources" it has "volumes".
    
    "This field maps into CSI volume IDs..." would be more appropriate



include/mesos/mesos.proto
Lines 1351 (patched)
<https://reviews.apache.org/r/62929/#comment264836>

    ditto: s/source/volume/


- James DeFelice


On Oct. 12, 2017, 11:39 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 11:39 a.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/1/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187868
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62929]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 12, 2017, 3:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187869
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 12, 2017, 3:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by James DeFelice <ja...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187804
-----------------------------------------------------------


Ship it!




Ship It!

- James DeFelice


On Oct. 12, 2017, 3:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187824
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['62929']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62929

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62929/logs/mesos-tests-stdout.log):

```
[       OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/0 (294 ms)
[ RUN      ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1
[       OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/1 (294 ms)
[ RUN      ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2
[       OK ] Endpoint/SlaveEndpointTest.UnauthorizedRequest/2 (340 ms)
[ RUN      ] Endpoint/SlaveEndpointTest.NoAuthorizer/0
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/0 (370 ms)
[ RUN      ] Endpoint/SlaveEndpointTest.NoAuthorizer/1
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/1 (296 ms)
[ RUN      ] Endpoint/SlaveEndpointTest.NoAuthorizer/2
[       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (303 ms)
[----------] 9 tests from Endpoint/SlaveEndpointTest (3111 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (142 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (153 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (348 ms total)

[----------] Global test environment tear-down
[==========] 723 tests from 73 test cases ran. (383260 ms total)
[  PASSED  ] 722 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam() = "mesos"

 1 FAILED TEST
  YOU HAVE 165 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62929/logs/mesos-tests-stderr.log):

```
I1012 17:48:52.716763 51456 containerizer.cpp:648] Recovering containerizer
I1012 17:48:52.735345 50304 provisioner.cpp:416] Provisioner recovery complete
I1012 17:48:52.737346 50428 slave.cpp:6310] Finished recovery
I1012 17:48:52.759347 51456 http.cpp:1185] HTTP GET for /slave(270)/monitor/statistics.json from 10.3.1.7:54650
I1012 17:48:52.760347 51456 http.cpp:976] Authorizing principal 'test-principal' to GET the '/monitor/statistics.json' endpoint
I1012 17:48:52.789347 51300 slave.cpp:869] Agent terminating
I1012 17:48:52.930351 49856 containerizer.cpp:292] Using isolation { windows/cpu, filesystem/windows, environment_secret }
I1012 17:48:52.932351 49856 provisioner.cpp:255] Using default backend 'copy'
I1012 17:48:52.950352 49856 cluster.cpp:448] Creating default 'local' authorizer
I1012 17:48:52.970352 51988 slave.cpp:254] Mesos agent started on (271)@10.3.1.7:53718
I1012 17:48:52.970352 51988 slave.cpp:255] Flags at startup: --acls="" --appc_simple_discovery_uri_prefix="http://" --appc_store_dir="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\store\appc" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticatee="crammd5" --authentication_backoff_factor="1secs" --authorizer="local" --container_disk_watch_interval="15secs" --containerizers="mesos" --credential="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\credential" --default_role="*" --disk_watch_interval="1mins" --docker="docker" --docker_kill_orphans="true" --docker_registry="https://registry-1.docker.io" --docker_remove_delay="6hrs" --docker_socket="//./pipe/docker_engine" --docker_stop_timeout="0ns" --docker_store_dir="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\store\docker" --docker_volume_checkpoint_dir="/var/run/mesos/isolators/docker/volume" --enforce_container_disk_quota="false" --executor_registration_timeout="1mins" --executor_reregistration_timeout="2secs" -
 -executor_shutdown_grace_period="5secs" --fetcher_cache_dir="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\fetch" --fetcher_cache_size="2GB" --frameworks_home="" --gc_delay="1weeks" --gc_disk_headroom="0.1" --hadoop_home="" --help="false" --hostname_lookup="true" --http_command_executor="false" --http_credentials="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\http_credentials" --http_heartbeat_interval="30secs" --initialize_driver_logging="true" --isolation="windows/cpu" --launcher="windows" --launcher_dir="C:\mesos\src" --logbufsecs="0" --logging_level="INFO" --max_completed_executors_per_framework="150" --oversubscribed_resources_interval="15secs" --port="5051" --qos_correction_interval_min="0ns" --quiet="false" --recover="reconnect" --recovery_timeout="15mins" --registration_backoff_factor="10ms" --resources="cpus:2;gpus:0;mem:1024;disk:1024;ports:[31000-32000]" --runtime_dir="C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k" --sandbox_directory="C:\mesos\sandbox" --strict="true" --version="
 false" --work_dir="C:\Users\mesos\AppData\Local\Temp\2\y2J3Od" --zk_session_timeout="10secs"
I1012 17:48:53.011358 51988 credentials.hpp:86] Loading credential for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\credential'
I1012 17:48:53.013355 51988 slave.cpp:287] Agent using credential for: test-principal
I1012 17:48:53.024356 51988 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\2\7sWQ5k\http_credentials'
I1012 17:48:53.026355 51988 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readonly'
I1012 17:48:53.027362 51988 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-agent-readwrite'
I1012 17:48:53.039356 51988 slave.cpp:585] Agent resources: [{"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}]
I1012 17:48:53.043356 51988 slave.cpp:593] Agent attributes: [  ]
I1012 17:48:53.043356 51988 slave.cpp:602] Agent hostname: mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1012 17:48:53.044356 50304 status_update_manager.cpp:177] Pausing sending status updates
I1012 17:48:53.054356 47400 state.cpp:64] Recovering state from 'C:\Users\mesos\AppData\Local\Temp\2\y2J3Od\meta'
I1012 17:48:53.058357 51456 status_update_manager.cpp:203] Recovering status update manager
I1012 17:48:53.059356 51988 containerizer.cpp:648] Recovering containerizer
I1012 17:48:53.065357 50304 provisioner.cpp:416] Provisioner recovery complete
I1012 17:48:53.067358 51336 slave.cpp:6310] Finished recovery
I1012 17:48:53.088356 47400 http.cpp:1185] HTTP GET for /slave(271)/containers from 10.3.1.7:54651
I1012 17:48:53.089356 47400 http.cpp:976] Authorizing principal 'test-principal' to GET the '/containers' endpoint
I1012 17:48:53.113359 50428 slave.cpp:869] Agent terminating
I1012 17:48:54.178392 48140 process.cpp:1068] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Oct. 12, 2017, 3:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 3:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Benjamin Bannier <bb...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/
-----------------------------------------------------------

(Updated Oct. 12, 2017, 5:34 p.m.)


Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.


Repository: mesos


Description
-------

This commit adds clarifying documentation to CSI-related proto fields
in `Resource.DiskInfo.Source` which were introduced earlier.


Diffs (updated)
-----

  include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
  include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 


Diff: https://reviews.apache.org/r/62929/diff/3/

Changes: https://reviews.apache.org/r/62929/diff/2-3/


Testing
-------

NFC.


Thanks,

Benjamin Bannier

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Benjamin Bannier <bb...@apache.org>.


> On Oct. 12, 2017, 4:53 p.m., James DeFelice wrote:
> > include/mesos/v1/mesos.proto
> > Lines 1328 (patched)
> > <https://reviews.apache.org/r/62929/diff/2/?file=1853363#file1853363line1328>
> >
> >     need the same s/source/volume/ changes for the v1 protos

Of course, sorry. Fixed now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187797
-----------------------------------------------------------


On Oct. 12, 2017, 5:34 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 5:34 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/3/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by James DeFelice <ja...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187797
-----------------------------------------------------------




include/mesos/v1/mesos.proto
Lines 1328 (patched)
<https://reviews.apache.org/r/62929/#comment264838>

    need the same s/source/volume/ changes for the v1 protos


- James DeFelice


On Oct. 12, 2017, 2:01 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 2:01 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/2/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Benjamin Bannier <bb...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/
-----------------------------------------------------------

(Updated Oct. 12, 2017, 4:01 p.m.)


Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.


Changes
-------

Tightened CSI-related language as suggested by jdef.


Repository: mesos


Description
-------

This commit adds clarifying documentation to CSI-related proto fields
in `Resource.DiskInfo.Source` which were introduced earlier.


Diffs (updated)
-----

  include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
  include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 


Diff: https://reviews.apache.org/r/62929/diff/2/

Changes: https://reviews.apache.org/r/62929/diff/1-2/


Testing
-------

NFC.


Thanks,

Benjamin Bannier

Re: Review Request 62929: Added documentation to CSI-related source proto fields.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62929/#review187789
-----------------------------------------------------------



PASS: Mesos patch 62929 was successfully built and tested.

Reviews applied: `['62929']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62929

- Mesos Reviewbot Windows


On Oct. 12, 2017, 7:39 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62929/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 7:39 p.m.)
> 
> 
> Review request for mesos, James DeFelice, Jie Yu, and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This commit adds clarifying documentation to CSI-related proto fields
> in `Resource.DiskInfo.Source` which were introduced earlier.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto ba87339dbe341f4d16ceea74adc09647a3c07f32 
>   include/mesos/v1/mesos.proto a6d662fb26aa4f78ef20ffe6e013f7a45f7f8c21 
> 
> 
> Diff: https://reviews.apache.org/r/62929/diff/1/
> 
> 
> Testing
> -------
> 
> NFC.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>