You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/01 05:14:03 UTC
[GitHub] [pulsar] freeznet opened a new pull request #9394: [go-functions] fix metrics server handler error
freeznet opened a new pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394
### Motivation
#9318 add metrics server to go function, but didnt serve `"/"` endpoint in metrics server, which will cause some metrics calls failed.
### Modifications
add handler for `"/"` in `MetricsServicer`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770600791
@freeznet the go functions test seems to fail.
```
2021/02/01 05:27:23.102 log.go:46: [info] Starting metrics server on port 50001
--- FAIL: TestMetricsServer (0.00s)
stats_test.go:198:
Error Trace: stats_test.go:198
Error: Not equal:
expected: <nil>(<nil>)
actual : *url.Error(&url.Error{Op:"Get", URL:"http://localhost:50001/", Err:(*net.OpError)(0xc0001cd770)})
Test: TestMetricsServer
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0xb52c50]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-771236942
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-771236942
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770907375
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770794320
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-771313618
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-771269665
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770591113
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770772700
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770810994
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #9394: [go-functions] fix metrics server handler error
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #9394:
URL: https://github.com/apache/pulsar/pull/9394#issuecomment-770895474
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org