You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Jukka Zitting <ju...@gmail.com> on 2012/01/04 18:13:10 UTC
Commit and contribution workflows (Was: Cordova-Android now
up-to-date in the ASF Git Repo)
Hi,
On Wed, Jan 4, 2012 at 5:46 PM, Viras <vi...@users.sourceforge.net> wrote:
> just to clarify: should I commit to github or to some apache git repository?
All Cordova committers should ideally push directly to the Cordova
repositories at git-wip-us.apache.org.
We can set up mirrors of those repositories on Github or elsewhere,
but for finely grained audit logs for code provenance the repositories
on Apache servers should be the primary push target. As soon as we are
happy with the functionality of the git-wip-us repositories, the
existing github.com/callback and github.com/cordova spaces should be
discontinued.
Contributors that are not yet Cordova committers can push their
changes to their personal clones on Github and send a pull request by
email to callback-dev@ (to be renamed) or to the appropriate CB issue.
The git-svn repositories mirrored at github.com/apache already support
automatic forwarding of pull request notifications to the respective
dev@ lists, so we could set up something similar also for Cordova if
there's interest. And of course changes can also be submitted as
normal patches even without any Git push/pull workflows.
It would be great if the Cordova community came up with a wiki or web
page that outlines the recommended contribution workflow.
Once a contributor has submitted enough good patches, he or she should
be granted Cordova committership and thus direct push access to the
Cordova repositories on git-wip-us.
BR,
Jukka Zitting
Re: Commit and contribution workflows (Was: Cordova-Android now up-to-date
in the ASF Git Repo)
Posted by Viras <vi...@users.sourceforge.net>.
No need to worry - I just wanted to make sure that I understand the
workflow correctly!
Best,
Wolfgang
Am 09.01.2012 19:53, schrieb Simon MacDonald:
> We are trying to figure it all out. Commit to the github site for now
> and we can push to the Apache site. Please bear with us as we continue
> to have growing pains.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
>
>
> On Wed, Jan 4, 2012 at 1:55 PM, Viras <vi...@users.sourceforge.net> wrote:
>> Hi,
>>
>> thanks - so even when I signed a CLA I have to commit to github until
>> cordova lead decides to give me commit access to the git-wip-us
>> repositories?
>>
>> Best,
>> Wolfgang
>>
>> Am 04.01.2012 18:13, schrieb Jukka Zitting:
>>> Hi,
>>>
>>> On Wed, Jan 4, 2012 at 5:46 PM, Viras <vi...@users.sourceforge.net> wrote:
>>>> just to clarify: should I commit to github or to some apache git repository?
>>>
>>> All Cordova committers should ideally push directly to the Cordova
>>> repositories at git-wip-us.apache.org.
>>>
>>> We can set up mirrors of those repositories on Github or elsewhere,
>>> but for finely grained audit logs for code provenance the repositories
>>> on Apache servers should be the primary push target. As soon as we are
>>> happy with the functionality of the git-wip-us repositories, the
>>> existing github.com/callback and github.com/cordova spaces should be
>>> discontinued.
>>>
>>> Contributors that are not yet Cordova committers can push their
>>> changes to their personal clones on Github and send a pull request by
>>> email to callback-dev@ (to be renamed) or to the appropriate CB issue.
>>> The git-svn repositories mirrored at github.com/apache already support
>>> automatic forwarding of pull request notifications to the respective
>>> dev@ lists, so we could set up something similar also for Cordova if
>>> there's interest. And of course changes can also be submitted as
>>> normal patches even without any Git push/pull workflows.
>>>
>>> It would be great if the Cordova community came up with a wiki or web
>>> page that outlines the recommended contribution workflow.
>>>
>>> Once a contributor has submitted enough good patches, he or she should
>>> be granted Cordova committership and thus direct push access to the
>>> Cordova repositories on git-wip-us.
>>>
>>> BR,
>>>
>>> Jukka Zitting
>>>
>>
>> --
>> GOFG - Get On Fat Guy
>> http://www.gofg.at/ - powered by PhoneGap
>
--
GOFG - Get On Fat Guy
http://www.gofg.at/ - powered by PhoneGap
Re: Commit and contribution workflows (Was: Cordova-Android now
up-to-date in the ASF Git Repo)
Posted by Simon MacDonald <si...@gmail.com>.
We are trying to figure it all out. Commit to the github site for now
and we can push to the Apache site. Please bear with us as we continue
to have growing pains.
Simon Mac Donald
http://hi.im/simonmacdonald
On Wed, Jan 4, 2012 at 1:55 PM, Viras <vi...@users.sourceforge.net> wrote:
> Hi,
>
> thanks - so even when I signed a CLA I have to commit to github until
> cordova lead decides to give me commit access to the git-wip-us
> repositories?
>
> Best,
> Wolfgang
>
> Am 04.01.2012 18:13, schrieb Jukka Zitting:
>> Hi,
>>
>> On Wed, Jan 4, 2012 at 5:46 PM, Viras <vi...@users.sourceforge.net> wrote:
>>> just to clarify: should I commit to github or to some apache git repository?
>>
>> All Cordova committers should ideally push directly to the Cordova
>> repositories at git-wip-us.apache.org.
>>
>> We can set up mirrors of those repositories on Github or elsewhere,
>> but for finely grained audit logs for code provenance the repositories
>> on Apache servers should be the primary push target. As soon as we are
>> happy with the functionality of the git-wip-us repositories, the
>> existing github.com/callback and github.com/cordova spaces should be
>> discontinued.
>>
>> Contributors that are not yet Cordova committers can push their
>> changes to their personal clones on Github and send a pull request by
>> email to callback-dev@ (to be renamed) or to the appropriate CB issue.
>> The git-svn repositories mirrored at github.com/apache already support
>> automatic forwarding of pull request notifications to the respective
>> dev@ lists, so we could set up something similar also for Cordova if
>> there's interest. And of course changes can also be submitted as
>> normal patches even without any Git push/pull workflows.
>>
>> It would be great if the Cordova community came up with a wiki or web
>> page that outlines the recommended contribution workflow.
>>
>> Once a contributor has submitted enough good patches, he or she should
>> be granted Cordova committership and thus direct push access to the
>> Cordova repositories on git-wip-us.
>>
>> BR,
>>
>> Jukka Zitting
>>
>
> --
> GOFG - Get On Fat Guy
> http://www.gofg.at/ - powered by PhoneGap
Re: Commit and contribution workflows (Was: Cordova-Android now up-to-date
in the ASF Git Repo)
Posted by Viras <vi...@users.sourceforge.net>.
Hi,
thanks - so even when I signed a CLA I have to commit to github until
cordova lead decides to give me commit access to the git-wip-us
repositories?
Best,
Wolfgang
Am 04.01.2012 18:13, schrieb Jukka Zitting:
> Hi,
>
> On Wed, Jan 4, 2012 at 5:46 PM, Viras <vi...@users.sourceforge.net> wrote:
>> just to clarify: should I commit to github or to some apache git repository?
>
> All Cordova committers should ideally push directly to the Cordova
> repositories at git-wip-us.apache.org.
>
> We can set up mirrors of those repositories on Github or elsewhere,
> but for finely grained audit logs for code provenance the repositories
> on Apache servers should be the primary push target. As soon as we are
> happy with the functionality of the git-wip-us repositories, the
> existing github.com/callback and github.com/cordova spaces should be
> discontinued.
>
> Contributors that are not yet Cordova committers can push their
> changes to their personal clones on Github and send a pull request by
> email to callback-dev@ (to be renamed) or to the appropriate CB issue.
> The git-svn repositories mirrored at github.com/apache already support
> automatic forwarding of pull request notifications to the respective
> dev@ lists, so we could set up something similar also for Cordova if
> there's interest. And of course changes can also be submitted as
> normal patches even without any Git push/pull workflows.
>
> It would be great if the Cordova community came up with a wiki or web
> page that outlines the recommended contribution workflow.
>
> Once a contributor has submitted enough good patches, he or she should
> be granted Cordova committership and thus direct push access to the
> Cordova repositories on git-wip-us.
>
> BR,
>
> Jukka Zitting
>
--
GOFG - Get On Fat Guy
http://www.gofg.at/ - powered by PhoneGap
Re: Commit and contribution workflows (Was: Cordova-Android now
up-to-date in the ASF Git Repo)
Posted by Filip Maj <fi...@adobe.com>.
WE'll need an Apache-blessed wiki I guess?
On 12-01-04 9:56 AM, "Jukka Zitting" <ju...@gmail.com> wrote:
>Hi,
>
>On Wed, Jan 4, 2012 at 6:40 PM, Filip Maj <fi...@adobe.com> wrote:
>>>It would be great if the Cordova community came up with a wiki or web
>>>page that outlines the recommended contribution workflow.
>>
>> Should we base this off the existing wiki articles floating around (the
>> ones that the CouchDB folks started?) or start a new one? Any
>> recommendations on this Jukka?
>
>Such a page needs to contain Cordova-specific information (like which
>repositories to use, any custom conventions to follow, etc.), but it
>can certainly refer to and be based on existing work by other
>projects.
>
>Some good reference material and existing examples are:
>
>* http://www.apache.org/foundation/getinvolved.html
>* http://httpd.apache.org/dev/patches.html
>* http://wiki.apache.org/hadoop/HowToContribute
>* http://activemq.apache.org/how-can-i-contribute.html
>* http://poi.apache.org/guidelines.html
>
>As you can see, each project has their own specific guidelines, but
>the basic message is pretty much the same: welcome!, get the source
>from here, take these things into considerations, here's how you
>submit a change, etc.
>
>BR,
>
>Jukka Zitting
Re: Commit and contribution workflows (Was: Cordova-Android now
up-to-date in the ASF Git Repo)
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On Wed, Jan 4, 2012 at 6:40 PM, Filip Maj <fi...@adobe.com> wrote:
>>It would be great if the Cordova community came up with a wiki or web
>>page that outlines the recommended contribution workflow.
>
> Should we base this off the existing wiki articles floating around (the
> ones that the CouchDB folks started?) or start a new one? Any
> recommendations on this Jukka?
Such a page needs to contain Cordova-specific information (like which
repositories to use, any custom conventions to follow, etc.), but it
can certainly refer to and be based on existing work by other
projects.
Some good reference material and existing examples are:
* http://www.apache.org/foundation/getinvolved.html
* http://httpd.apache.org/dev/patches.html
* http://wiki.apache.org/hadoop/HowToContribute
* http://activemq.apache.org/how-can-i-contribute.html
* http://poi.apache.org/guidelines.html
As you can see, each project has their own specific guidelines, but
the basic message is pretty much the same: welcome!, get the source
from here, take these things into considerations, here's how you
submit a change, etc.
BR,
Jukka Zitting
Re: Commit and contribution workflows (Was: Cordova-Android now
up-to-date in the ASF Git Repo)
Posted by Filip Maj <fi...@adobe.com>.
>The git-svn repositories mirrored at github.com/apache already support
>automatic forwarding of pull request notifications to the respective
>dev@ lists, so we could set up something similar also for Cordova if
>there's interest. And of course changes can also be submitted as
>normal patches even without any Git push/pull workflows.
This sounds like the best solution. This way we don't have to give up the
simplicity of GitHub for getting contributions from non-committers, but
can still stay almost completely within Apache infrastructure for
day-to-day development. Also makes sense to have it under the Apache
organization on GitHub...
>It would be great if the Cordova community came up with a wiki or web
>page that outlines the recommended contribution workflow.
Should we base this off the existing wiki articles floating around (the
ones that the CouchDB folks started?) or start a new one? Any
recommendations on this Jukka?