You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Min Zhou (JIRA)" <ji...@apache.org> on 2009/03/03 02:09:56 UTC
[jira] Created: (HIVE-317) HiveServer can not define its port
correctly
HiveServer can not define its port correctly
---------------------------------------------
Key: HIVE-317
URL: https://issues.apache.org/jira/browse/HIVE-317
Project: Hadoop Hive
Issue Type: Bug
Components: Server Infrastructure
Affects Versions: 0.3.0
Reporter: Min Zhou
HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
By digging into the source code, I found it may caused by these lines of main function.
if (args.length > 1) {
port = Integer.getInteger(args[0]);
}
I think they should be:
if (args.length >= 1) {
port = Integer.parseInt(args[0]);
}
The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Min Zhou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Min Zhou updated HIVE-317:
--------------------------
Attachment: hiveserver.patch
solution
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Attachments: hiveserver.patch
>
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-317:
----------------------------
Fix Version/s: 0.3.0
Status: Patch Available (was: Open)
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Fix For: 0.3.0
>
> Attachments: hiveserver.patch
>
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682769#action_12682769 ]
Ashish Thusoo commented on HIVE-317:
------------------------------------
+1
Am running test on this. Will check in once the tests succeed.
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Assignee: Min Zhou
> Fix For: 0.3.0
>
> Attachments: hiveserver.patch
>
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo updated HIVE-317:
-------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
committed. Thanks Min!!
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Assignee: Min Zhou
> Fix For: 0.3.0
>
> Attachments: hiveserver.patch
>
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12678358#action_12678358 ]
Zheng Shao commented on HIVE-317:
---------------------------------
Looks good. Can you submit a patch?
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-317) HiveServer can not define its port
correctly
Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Thusoo reassigned HIVE-317:
----------------------------------
Assignee: Min Zhou
Added Min as a contributor and assigned the bug.
> HiveServer can not define its port correctly
> ---------------------------------------------
>
> Key: HIVE-317
> URL: https://issues.apache.org/jira/browse/HIVE-317
> Project: Hadoop Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.3.0
> Reporter: Min Zhou
> Assignee: Min Zhou
> Fix For: 0.3.0
>
> Attachments: hiveserver.patch
>
>
> HiveServer.java accept one argument stands for the port of this server, but I found that can not accept this argument.
> By digging into the source code, I found it may caused by these lines of main function.
> if (args.length > 1) {
> port = Integer.getInteger(args[0]);
> }
> I think they should be:
> if (args.length >= 1) {
> port = Integer.parseInt(args[0]);
> }
> The author may have some different intention, I think.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.