You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Tanping Wang (JIRA)" <ji...@apache.org> on 2011/06/20 23:54:47 UTC
[jira] [Created] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
--------------------------------------------------------------------------------------------------------
Key: HDFS-2086
URL: https://issues.apache.org/jira/browse/HDFS-2086
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Tanping Wang
As the tile describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Status: Open (was: Patch Available)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Status: Open (was: Patch Available)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052769#comment-13052769 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483317/HDFS-2086.2.patch
against trunk revision 1138098.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.namenode.TestBlocksWithNotEnoughRacks
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/807//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/807//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/807//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052244#comment-13052244 ]
Tanping Wang commented on HDFS-2086:
------------------------------------
There is a second part of this problem. When namenode checks datanode status by calling
FSNameSystem#getDatanodeListForReport
The namenode goes over its include hosts list and tries to determine if all the hosts in the include list are all registrant. If not, the host will be added into the dead list. In our case, as just mentioned early, after the namenode restarted, datanode registrants itself with its *IP address*. But the include list still
contains its *host name*. So the hostname is not recognized by namenode and is added into the dead list when namenode reports the datanodes status.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Fix For: 0.23.0
>
>
> As the tile describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052297#comment-13052297 ]
Jitendra Nath Pandey commented on HDFS-2086:
--------------------------------------------
1. inHostsList and inExcludeHostsList do same things on two different lists. Both can use a single method that also takes the list as argument.
2. Do we really need to look into hostsList for both node.getName and iaddr.getHostName? I understand node.getName may actually be returning the ip:port, but for IP iaddr.getHostAddress is more reliable. Caveat with the later approach: Can we assume ipAddr and node (DatanodeID) will always be for the same host?
Minor: Indentation in checkIncludeListForDead.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052314#comment-13052314 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483221/HDFS-2086.patch
against trunk revision 1137675.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.namenode.TestStartup
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/802//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/802//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/802//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053560#comment-13053560 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483519/HDFS-2086.5.patch
against trunk revision 1138645.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/822//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/822//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/822//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.7.patch
Address the review comments.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054422#comment-13054422 ]
Hudson commented on HDFS-2086:
------------------------------
Integrated in Hadoop-Hdfs-trunk #705 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/705/])
HDFS-2086. If the include hosts list contains host names, after restarting namenode, data nodes registration is denied. Contributed by Tanping Wang.
tanping : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1139090
Files :
* /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.patch
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.4.patch
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054147#comment-13054147 ]
Hudson commented on HDFS-2086:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #755 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/755/])
HDFS-2086. If the include hosts list contains host names, after restarting namenode, data nodes registration is denied. Contributed by Tanping Wang.
tanping : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1139090
Files :
* /hadoop/common/trunk/hdfs/src/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hdfs/CHANGES.txt
* /hadoop/common/trunk/hdfs/src/test/hdfs/org/apache/hadoop/hdfs/server/namenode/TestStartup.java
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054050#comment-13054050 ]
Jitendra Nath Pandey commented on HDFS-2086:
--------------------------------------------
Patch looks good to me
nit: In checkInList, can we avoid repeating (iaddr != null)?
+1 otherwise.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Status: Patch Available (was: Open)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Status: Patch Available (was: Open)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Description:
As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
was:
As the tile describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054128#comment-13054128 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483638/HDFS-2086.7.patch
against trunk revision 1138645.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/830//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/830//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/830//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052910#comment-13052910 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483349/HDFS-2086.3.patch
against trunk revision 1138098.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/811//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/811//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/811//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.7.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.5.patch
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053006#comment-13053006 ]
Hadoop QA commented on HDFS-2086:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483384/HDFS-2086.4.patch
against trunk revision 1138262.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/813//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/813//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/813//console
This message is automatically generated.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Component/s: name-node
Affects Version/s: 0.23.0
Fix Version/s: 0.23.0
Assignee: Tanping Wang
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
>
> As the tile describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.6.patch
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.4.patch, HDFS-2086.5.patch, HDFS-2086.6.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.2.patch
Upload a new patch to address the review comments.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HDFS-2086:
---------------------------------------
Status: Patch Available (was: Open)
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-2086) If the include hosts list contains
host name, after restarting namenode, datanodes registrant is denied
Posted by "Tanping Wang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-2086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tanping Wang updated HDFS-2086:
-------------------------------
Attachment: HDFS-2086.3.patch
Upload a new patch to fix the failed unit test case.
> If the include hosts list contains host name, after restarting namenode, datanodes registrant is denied
> --------------------------------------------------------------------------------------------------------
>
> Key: HDFS-2086
> URL: https://issues.apache.org/jira/browse/HDFS-2086
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.23.0
> Reporter: Tanping Wang
> Assignee: Tanping Wang
> Fix For: 0.23.0
>
> Attachments: HDFS-2086.2.patch, HDFS-2086.3.patch, HDFS-2086.patch
>
>
> As the title describes the problem: if the include host list contains host name, after restarting namenodes, the datanodes registrant is denied by namenodes. This is because after namenode is restarted, the still alive data node will try to register itself with the namenode and it identifies itself with its *IP address*. However, namenode only allows all the hosts in its hosts list to registrant and all of them are hostnames. So namenode would deny the datanode registration.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira