You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/07/13 13:01:00 UTC
[jira] [Work logged] (HDFS-16658) BlockManager should output some logs when logEveryBlock is true.
[ https://issues.apache.org/jira/browse/HDFS-16658?focusedWorklogId=790418&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-790418 ]
ASF GitHub Bot logged work on HDFS-16658:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/22 13:00
Start Date: 13/Jul/22 13:00
Worklog Time Spent: 10m
Work Description: ZanderXu opened a new pull request, #4559:
URL: https://github.com/apache/hadoop/pull/4559
### Description of PR
During locating some abnormal cases about block replication in our prod environment, I found that BlockManager does not out put some logs in `addStoredBlock` even though `logEveryBlock` is true.
I feel that we need to change the log level from DEBUG to INFO when `logEveryBlock` is true. So that we can more easily locate some abnormal cases.
```
private Block addStoredBlock(final BlockInfo block,
final Block reportedBlock,
DatanodeStorageInfo storageInfo,
DatanodeDescriptor delNodeHint,
boolean logEveryBlock)
throws IOException {
....
if (logEveryBlock) {
blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
node, storedBlock, storedBlock.getNumBytes());
}
...
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 790418)
Remaining Estimate: 0h
Time Spent: 10m
> BlockManager should output some logs when logEveryBlock is true.
> ----------------------------------------------------------------
>
> Key: HDFS-16658
> URL: https://issues.apache.org/jira/browse/HDFS-16658
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> During locating some abnormal cases in our prod environment, I found that BlockManager does not out put some logs in `addStoredBlock` even though `logEveryBlock` is true.
> I feel that we need to change the log level from DEBUG to INFO.
> {code:java}
> // Some comments here
> private Block addStoredBlock(final BlockInfo block,
> final Block reportedBlock,
> DatanodeStorageInfo storageInfo,
> DatanodeDescriptor delNodeHint,
> boolean logEveryBlock)
> throws IOException {
> ....
> if (logEveryBlock) {
> blockLog.debug("BLOCK* addStoredBlock: {} is added to {} (size={})",
> node, storedBlock, storedBlock.getNumBytes());
> }
> ...
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org