[jira] [Commented] (SOLR-8191) CloudSolrStream close method NullPointerException

["Jason Gerlowski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15059213#comment-15059213 ] 

Jason Gerlowski commented on SOLR-8191:
---------------------------------------

The current patch still applies cleanly.  Fixing this NPE might not be hugely important, but this bug is blocking SOLR-8190, which would be a nice improvement IMO. (Not a huge deal, but still a nice little tidbit).

Looking at {{CloudSolrStream}} a little closer though, it seems odd to perform a null-check on {{close()}}, but not any of the other places that {{cloudSolrClient}} is used.  For instance, check out the protected {{constructStreams()}} method, which is invoked on each call to {{open()}}.

Those are just my observations at a glance.  I'm not very familiar with the SolrJ code, so maybe this isn't actually an issue.  Just wanted to mention it.  I'm going to tinker around with this more tonight to see if I can learn more.

> CloudSolrStream close method NullPointerException
> -------------------------------------------------
>
>                 Key: SOLR-8191
>                 URL: https://issues.apache.org/jira/browse/SOLR-8191
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ
>    Affects Versions: Trunk
>            Reporter: Kevin Risden
>         Attachments: SOLR-8191.patch
>
>
> CloudSolrStream doesn't check if cloudSolrClient or solrStreams is null yielding a NullPointerException in those cases when close() is called on it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org