You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/27 01:46:51 UTC
[GitHub] [arrow-rs] Jimexist opened a new pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Jimexist opened a new pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724
# Which issue does this PR close?
specifying rust 1.53 for `arrow` and `parquet` crate.
related #714
Closes #.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-907103285
> > I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.
>
> sadly this option is ready in 1.56 by which time rust edition 2021 is already out
For now it only displays a warning, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-906868177
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#724](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b94047) into [master](https://codecov.io/gh/apache/arrow-rs/commit/5a12d9749aa088e7abc4020e30238cf556499617?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a12d97) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
- Coverage 82.50% 82.49% -0.01%
==========================================
Files 168 168
Lines 47589 47589
==========================================
- Hits 39261 39260 -1
- Misses 8328 8329 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow-rs/pull/724/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZW5jb2RpbmdzL2VuY29kaW5nLnJz) | `94.48% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a12d97...5b94047](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-907611862
An alternate is to document that arrow rs only tests on the latest rust stable: https://github.com/apache/arrow-rs/pull/726
If the goal is to ensure that the `arrow` and `parquet` crates work on Rust 1.53 I suggest we add a CI run that at least `cargo check`s that they can be compiled with 1.53.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-906866115
actually this doesn't work.
see also https://doc.rust-lang.org/nightly/cargo/reference/manifest.html#the-rust-version-field but sadly this is nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist closed pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
Jimexist closed pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Jimexist commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-907097085
> I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.
sadly this option is ready in 1.56 by which time rust edition 2021 is already out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] houqp commented on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-906896661
I feel like we could still merge as is and wait for the stable toolchain to catch up evetually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #724: specifying rust 1.53 for `arrow` and `parquet` crate
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #724:
URL: https://github.com/apache/arrow-rs/pull/724#issuecomment-906868177
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#724](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d64b62c) into [master](https://codecov.io/gh/apache/arrow-rs/commit/deb31a0e9df45e0aa4f8e12e57ced9d0ce8c579c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (deb31a0) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 82.51% 82.51%
=======================================
Files 168 168
Lines 47647 47647
=======================================
Hits 39317 39317
Misses 8330 8330
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [deb31a0...d64b62c](https://codecov.io/gh/apache/arrow-rs/pull/724?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org