[jira] [Commented] (IMPALA-11384) Upgrade CPP thrift components to thrift-0.16.0

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558698#comment-17558698 ] 

ASF subversion and git services commented on IMPALA-11384:
----------------------------------------------------------

Commit 1bcb35ec7930db1b96a8c018fc4fcf7dbe3a75c7 in impala's branch refs/heads/master from Riza Suminto
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1bcb35ec7 ]

IMPALA-11384: Upgrade CPP thrift components to thrift-0.16.0

This patch upgrades IMPALA_THRIFT_CPP_VERSION=0.16.0-p3 to mitigate
CVE-2020-13949 and hang issue with newer JDBC client.
IMPALA_TOOLCHAIN_BUILD_ID is upgraded to 179-9977806f06, which contains
the required thrift-0.16.0 compiler.

The refactoring itself includes:
- Removing non-generated (empty) *_constants.cpp and adjustment for
  THRIFT-4730.
- Adjusts error handling in client-request-state.cc due to changing
  thrift error message after the upgrade.
- Adding custom build target thrift-cpp-manual-edit to fix
  clang-diagnostic-inconsistent-missing-override warning in generated
  ImpalaHiveServer2Service.h and ImpalaService.h

Testing:
- Build and pass core tests.

Change-Id: Ic278ac5c973ff5c3e829a6139b9c16e9d2c62a59
Reviewed-on: http://gerrit.cloudera.org:8080/18661
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Joe McDonnell <jo...@cloudera.com>


> Upgrade CPP thrift components to thrift-0.16.0
> ----------------------------------------------
>
>                 Key: IMPALA-11384
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11384
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: Impala 4.1.0
>            Reporter: Riza Suminto
>            Assignee: Riza Suminto
>            Priority: Major
>
> Between thrift-0.14.2 and thrift-0.16.0, they generate similar C++ code. Upgrading straight to thrift-0.16.0 also going to avoid us from manually patching THRIFT-5418 ourselves.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org