You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/25 08:16:00 UTC
[GitHub] [incubator-kyuubi] deadwind4 opened a new pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
deadwind4 opened a new pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Add flink usage detail document to show how to use in standalone and how to set flink option etc.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r837081836
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
Review comment:
Thanks a lot, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855400
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
+ newOutput += ""
+ newOutput += ("For example:")
+ newOutput += ("```")
+ newOutput += ("flink.parallelism.default 2")
+ newOutput += ("flink.taskmanager.memory.process.size 5g")
Review comment:
~~Does 5g is the default value? We'd better use the default value in example~~
Ignore it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r838162080
##########
File path: docs/deployment/flink/basics.md
##########
@@ -0,0 +1,92 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+
+
+</div>
+
+# Basics
Review comment:
In the future, we make a FlinkSQLEngine Q&A docs about the `execution.target` option. Now, I delete `flink/basics.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r837006254
##########
File path: docs/deployment/flink/basics.md
##########
@@ -0,0 +1,92 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+
+
+</div>
+
+# Basics
Review comment:
Users often forget to configure `execution.target`, resulting in the running result of Kyuubi not meeting expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836978261
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -117,29 +117,37 @@ Kyuubi currently does not support Spark's [YARN-specific Kerberos Configuration]
so `spark.kerberos.keytab` and `spark.kerberos.principal` should not use now.
Instead, you can schedule a periodically `kinit` process via `crontab` task on the local machine that hosts Kyuubi server or simply use [Kyuubi Kinit](settings.html#kinit).
-
- ## Deploy Kyuubi Flink Engine on Yarn
-
- ### Requirements
-
- When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
-
- - Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
- - A binary distribution of Flink which is built with YARN support
- - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
- - An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
- - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
- - An active Apache Hadoop HDFS cluster
- - Setup Hadoop client configurations at the machine the Kyuubi server locates
-
- ### Configurations
-
- #### Environment
-
- Either `HADOOP_CONF_DIR` or `YARN_CONF_DIR` is configured and points to the Hadoop client configurations directory, usually, `$HADOOP_HOME/etc/hadoop`.
-
- If the `HADOOP_CONF_DIR` points the YARN and HDFS cluster correctly, and the `HADOOP_CLASSPATH` environment variable is set, you can launch a Flink on YARN session, and submit an example job:
- ```bash
+
+## Deploy Kyuubi Flink Engine on Yarn
Review comment:
You only add `Yarn Session Mode` in this document. Other changes are invalid and could be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b7911f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
- Coverage 61.69% 61.66% -0.03%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 15936 -20
Branches 2028 2024 -4
============================================
- Hits 9844 9827 -17
- Misses 5291 5294 +3
+ Partials 821 815 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| [...org/apache/kyuubi/engine/spark/schema/RowSet.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvUm93U2V0LnNjYWxh) | `92.30% <0.00%> (+1.56%)` | :arrow_up: |
| [...ain/scala/org/apache/kyuubi/util/RowSetUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL1Jvd1NldFV0aWxzLnNjYWxh) | `85.71% <0.00%> (+7.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...5b7911f](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836980617
##########
File path: docs/deployment/flink/basics.md
##########
@@ -0,0 +1,92 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+
+
+</div>
+
+# Basics
Review comment:
IMO, the `basic.md` is unnecessary for the Flink engine users because the users should have the knowledge of the Flink configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (408c332) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **increase** coverage by `0.22%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
+ Coverage 61.69% 61.91% +0.22%
Complexity 69 69
============================================
Files 332 333 +1
Lines 15956 16107 +151
Branches 2028 2052 +24
============================================
+ Hits 9844 9973 +129
+ Misses 5291 5290 -1
- Partials 821 844 +23
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/spark/kyuubi/SparkContextHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrQ29udGV4dEhlbHBlci5zY2FsYQ==) | `52.94% <0.00%> (-4.96%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `90.10% <0.00%> (-4.01%)` | :arrow_down: |
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.89% <0.00%> (-3.13%)` | :arrow_down: |
| [.../kyuubi/credentials/HadoopCredentialsManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BDcmVkZW50aWFsc01hbmFnZXIuc2NhbGE=) | `93.12% <0.00%> (-2.53%)` | :arrow_down: |
| [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `95.00% <0.00%> (-2.30%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `94.11% <0.00%> (-1.97%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.35% <0.00%> (-1.78%)` | :arrow_down: |
| [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.96% <0.00%> (-1.33%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.97% <0.00%> (-0.20%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...408c332](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5b7911f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5b7911f differs from pull request most recent head 8eacc13. Consider uploading reports for the commit 8eacc13 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
- Coverage 61.69% 61.66% -0.03%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 15936 -20
Branches 2028 2024 -4
============================================
- Hits 9844 9827 -17
- Misses 5291 5294 +3
+ Partials 821 815 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| [...org/apache/kyuubi/engine/spark/schema/RowSet.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvUm93U2V0LnNjYWxh) | `92.30% <0.00%> (+1.56%)` | :arrow_up: |
| [...ain/scala/org/apache/kyuubi/util/RowSetUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS91dGlsL1Jvd1NldFV0aWxzLnNjYWxh) | `85.71% <0.00%> (+7.45%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...8eacc13](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835854936
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
Review comment:
Can we link a released version? The nightlies docs changing everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836984542
##########
File path: docs/deployment/settings.md
##########
@@ -396,6 +396,32 @@ Setting them in the JDBC Connection URL supplies session-specific for each SQL e
Please refer to the Spark official online documentation for [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)
+## Flink Configurations
+
+### Via flink-conf.yaml
+
+Setting them in `$FLINK_HOME/conf/flink-conf.yaml` supplies with default values for SQL engine application. Available properties can be found at Flink official online documentation for [Flink Configurations](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)
+
+### Via kyuubi-defaults.conf
+
+Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf` supplies with default values for SQL engine application too. You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`.
+
+For example:
+```
+flink.parallelism.default 2
+flink.taskmanager.memory.process.size 5g
Review comment:
```suggestion
flink.taskmanager.memory.process.size: 5g
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836996248
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -117,29 +117,37 @@ Kyuubi currently does not support Spark's [YARN-specific Kerberos Configuration]
so `spark.kerberos.keytab` and `spark.kerberos.principal` should not use now.
Instead, you can schedule a periodically `kinit` process via `crontab` task on the local machine that hosts Kyuubi server or simply use [Kyuubi Kinit](settings.html#kinit).
-
- ## Deploy Kyuubi Flink Engine on Yarn
-
- ### Requirements
-
- When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
-
- - Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
- - A binary distribution of Flink which is built with YARN support
- - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
- - An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
- - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
- - An active Apache Hadoop HDFS cluster
- - Setup Hadoop client configurations at the machine the Kyuubi server locates
-
- ### Configurations
-
- #### Environment
-
- Either `HADOOP_CONF_DIR` or `YARN_CONF_DIR` is configured and points to the Hadoop client configurations directory, usually, `$HADOOP_HOME/etc/hadoop`.
-
- If the `HADOOP_CONF_DIR` points the YARN and HDFS cluster correctly, and the `HADOOP_CLASSPATH` environment variable is set, you can launch a Flink on YARN session, and submit an example job:
- ```bash
+
+## Deploy Kyuubi Flink Engine on Yarn
Review comment:
Other changes are deleting unuseful space. Previously, there is a space at the beginning of each line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836013883
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
Review comment:
As the Flink version is updated too fast, I prefer to use nightlies/master docs. And users can jump low version in master docs, but the inverse is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855400
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
+ newOutput += ""
+ newOutput += ("For example:")
+ newOutput += ("```")
+ newOutput += ("flink.parallelism.default 2")
+ newOutput += ("flink.taskmanager.memory.process.size 5g")
Review comment:
Does 5g is the default value? We'd better use default value in example
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
+ newOutput += ""
+ newOutput += ("For example:")
+ newOutput += ("```")
+ newOutput += ("flink.parallelism.default 2")
+ newOutput += ("flink.taskmanager.memory.process.size 5g")
Review comment:
Does 5g is the default value? We'd better use the default value in example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855949
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
Review comment:
It does not point the additional prefix `flink.`, how about changing it to "You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836984487
##########
File path: docs/deployment/settings.md
##########
@@ -396,6 +396,32 @@ Setting them in the JDBC Connection URL supplies session-specific for each SQL e
Please refer to the Spark official online documentation for [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)
+## Flink Configurations
+
+### Via flink-conf.yaml
+
+Setting them in `$FLINK_HOME/conf/flink-conf.yaml` supplies with default values for SQL engine application. Available properties can be found at Flink official online documentation for [Flink Configurations](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)
+
+### Via kyuubi-defaults.conf
+
+Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf` supplies with default values for SQL engine application too. You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`.
+
+For example:
+```
+flink.parallelism.default 2
Review comment:
```suggestion
flink.parallelism.default: 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r837004183
##########
File path: docs/deployment/flink/basics.md
##########
@@ -0,0 +1,92 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+
+
+</div>
+
+# Basics
Review comment:
This document ensures that users can absolutely run a Flink job. The vast majority of users who read documents are not so familiar with Flink and Kyuubi. This document can be displayed directly when we answer questions in the community. Users can retrieve all knowledge through it. A novice of Flink and Kyuubi can jump to other required information through this document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855165
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -117,29 +117,37 @@ Kyuubi currently does not support Spark's [YARN-specific Kerberos Configuration]
so `spark.kerberos.keytab` and `spark.kerberos.principal` should not use now.
Instead, you can schedule a periodically `kinit` process via `crontab` task on the local machine that hosts Kyuubi server or simply use [Kyuubi Kinit](settings.html#kinit).
-
- ## Deploy Kyuubi Flink Engine on Yarn
-
- ### Requirements
-
- When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
-
- - Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
- - A binary distribution of Flink which is built with YARN support
- - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
- - An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
- - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
- - An active Apache Hadoop HDFS cluster
- - Setup Hadoop client configurations at the machine the Kyuubi server locates
-
- ### Configurations
-
- #### Environment
-
- Either `HADOOP_CONF_DIR` or `YARN_CONF_DIR` is configured and points to the Hadoop client configurations directory, usually, `$HADOOP_HOME/etc/hadoop`.
-
- If the `HADOOP_CONF_DIR` points the YARN and HDFS cluster correctly, and the `HADOOP_CLASSPATH` environment variable is set, you can launch a Flink on YARN session, and submit an example job:
- ```bash
+
+## Deploy Kyuubi Flink Engine on Yarn
+
+### Requirements
+
+When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
+
+- Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
+- A binary distribution of Flink which is built with YARN support
+ - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
+- An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
+ - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
+- An active Apache Hadoop HDFS cluster
Review comment:
Seems not a hard dependency, can be replaced by Object Storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836988050
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -160,14 +168,14 @@ export HADOOP_CLASSPATH=`hadoop classpath`
# on the output of the yarn-session.sh command)
echo "stop" | ./bin/yarn-session.sh -id application_XXXXX_XXX
```
-
- If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
-
- ```bash
- $ echo "export HADOOP_CONF_DIR=/path/to/hadoop/conf" >> $KYUUBI_HOME/conf/kyuubi-env.sh
- ```
-#### Deployment Modes Supported by Flink on YARN
+If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
Review comment:
delete unuseful space/' '
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eacc13) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 8eacc13 differs from pull request most recent head 246e550. Consider uploading reports for the commit 246e550 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
+ Coverage 61.69% 61.81% +0.12%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 16031 +75
Branches 2028 2032 +4
============================================
+ Hits 9844 9910 +66
- Misses 5291 5296 +5
- Partials 821 825 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.89% <0.00%> (-3.13%)` | :arrow_down: |
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `95.00% <0.00%> (-2.30%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `94.11% <0.00%> (-1.97%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.35% <0.00%> (-1.78%)` | :arrow_down: |
| [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.96% <0.00%> (-1.33%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.16% <0.00%> (-0.01%)` | :arrow_down: |
| [...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvU2VydmljZUNvbnRyb2xDbGkuc2NhbGE=) | `77.57% <0.00%> (ø)` | |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...246e550](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836978573
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -160,14 +168,14 @@ export HADOOP_CLASSPATH=`hadoop classpath`
# on the output of the yarn-session.sh command)
echo "stop" | ./bin/yarn-session.sh -id application_XXXXX_XXX
```
-
- If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
-
- ```bash
- $ echo "export HADOOP_CONF_DIR=/path/to/hadoop/conf" >> $KYUUBI_HOME/conf/kyuubi-env.sh
- ```
-#### Deployment Modes Supported by Flink on YARN
+If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
Review comment:
Are there any changes here? If no, please rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078781156
@SteNicholas please review it, thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855949
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
Review comment:
It does not point the **additional prefix** `flink.`, how about changing it to "You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`."?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r837046107
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation for" +
" [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online documentation for" +
+ " [Flink Configurations]" +
+ "(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
Review comment:
use https://nightlies.apache.org/flink/flink-docs-stable/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (246e550) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **increase** coverage by `0.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 246e550 differs from pull request most recent head 408c332. Consider uploading reports for the commit 408c332 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
+ Coverage 61.69% 61.92% +0.23%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 16051 +95
Branches 2028 2036 +8
============================================
+ Hits 9844 9940 +96
+ Misses 5291 5282 -9
- Partials 821 829 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.89% <0.00%> (-3.13%)` | :arrow_down: |
| [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `95.00% <0.00%> (-2.30%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.35% <0.00%> (-1.78%)` | :arrow_down: |
| [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.96% <0.00%> (-1.33%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.16% <0.00%> (-0.01%)` | :arrow_down: |
| [...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvU2VydmljZUNvbnRyb2xDbGkuc2NhbGE=) | `77.57% <0.00%> (ø)` | |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `85.59% <0.00%> (+0.24%)` | :arrow_up: |
| [...e/kyuubi/engine/spark/operation/ExecuteScala.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVNjYWxhLnNjYWxh) | `83.87% <0.00%> (+1.11%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...408c332](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836978261
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -117,29 +117,37 @@ Kyuubi currently does not support Spark's [YARN-specific Kerberos Configuration]
so `spark.kerberos.keytab` and `spark.kerberos.principal` should not use now.
Instead, you can schedule a periodically `kinit` process via `crontab` task on the local machine that hosts Kyuubi server or simply use [Kyuubi Kinit](settings.html#kinit).
-
- ## Deploy Kyuubi Flink Engine on Yarn
-
- ### Requirements
-
- When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
-
- - Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
- - A binary distribution of Flink which is built with YARN support
- - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
- - An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
- - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
- - An active Apache Hadoop HDFS cluster
- - Setup Hadoop client configurations at the machine the Kyuubi server locates
-
- ### Configurations
-
- #### Environment
-
- Either `HADOOP_CONF_DIR` or `YARN_CONF_DIR` is configured and points to the Hadoop client configurations directory, usually, `$HADOOP_HOME/etc/hadoop`.
-
- If the `HADOOP_CONF_DIR` points the YARN and HDFS cluster correctly, and the `HADOOP_CLASSPATH` environment variable is set, you can launch a Flink on YARN session, and submit an example job:
- ```bash
+
+## Deploy Kyuubi Flink Engine on Yarn
Review comment:
You only add `Yarn Session Mode` in this document. Other changes are invalid and could be rollback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836978573
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -160,14 +168,14 @@ export HADOOP_CLASSPATH=`hadoop classpath`
# on the output of the yarn-session.sh command)
echo "stop" | ./bin/yarn-session.sh -id application_XXXXX_XXX
```
-
- If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
-
- ```bash
- $ echo "export HADOOP_CONF_DIR=/path/to/hadoop/conf" >> $KYUUBI_HOME/conf/kyuubi-env.sh
- ```
-#### Deployment Modes Supported by Flink on YARN
+If the `TopSpeedWindowing` passes, configure it in `$KYUUBI_HOME/conf/kyuubi-env.sh` or `$FLINK_HOME/bin/config.sh`, e.g.
Review comment:
Are there any changes here? If no, please revert these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836988176
##########
File path: docs/deployment/settings.md
##########
@@ -396,6 +396,32 @@ Setting them in the JDBC Connection URL supplies session-specific for each SQL e
Please refer to the Spark official online documentation for [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)
+## Flink Configurations
+
+### Via flink-conf.yaml
+
+Setting them in `$FLINK_HOME/conf/flink-conf.yaml` supplies with default values for SQL engine application. Available properties can be found at Flink official online documentation for [Flink Configurations](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)
+
+### Via kyuubi-defaults.conf
+
+Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf` supplies with default values for SQL engine application too. You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`.
+
+For example:
+```
+flink.parallelism.default 2
Review comment:
this is kyuubi conf no ':'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8eacc13) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
+ Coverage 61.69% 61.81% +0.12%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 16031 +75
Branches 2028 2032 +4
============================================
+ Hits 9844 9910 +66
- Misses 5291 5296 +5
- Partials 821 825 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.89% <0.00%> (-3.13%)` | :arrow_down: |
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `95.00% <0.00%> (-2.30%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `94.11% <0.00%> (-1.97%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.35% <0.00%> (-1.78%)` | :arrow_down: |
| [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.96% <0.00%> (-1.33%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.16% <0.00%> (-0.01%)` | :arrow_down: |
| [...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvU2VydmljZUNvbnRyb2xDbGkuc2NhbGE=) | `77.57% <0.00%> (ø)` | |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...8eacc13](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836988298
##########
File path: docs/deployment/settings.md
##########
@@ -396,6 +396,32 @@ Setting them in the JDBC Connection URL supplies session-specific for each SQL e
Please refer to the Spark official online documentation for [SET Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)
+## Flink Configurations
+
+### Via flink-conf.yaml
+
+Setting them in `$FLINK_HOME/conf/flink-conf.yaml` supplies with default values for SQL engine application. Available properties can be found at Flink official online documentation for [Flink Configurations](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)
+
+### Via kyuubi-defaults.conf
+
+Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf` supplies with default values for SQL engine application too. You can use properties with the additional prefix `flink.` to override settings in `$FLINK_HOME/conf/flink-conf.yaml`.
+
+For example:
+```
+flink.parallelism.default 2
+flink.taskmanager.memory.process.size 5g
Review comment:
this is a kyuubi conf no ':'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855165
##########
File path: docs/deployment/engine_on_yarn.md
##########
@@ -117,29 +117,37 @@ Kyuubi currently does not support Spark's [YARN-specific Kerberos Configuration]
so `spark.kerberos.keytab` and `spark.kerberos.principal` should not use now.
Instead, you can schedule a periodically `kinit` process via `crontab` task on the local machine that hosts Kyuubi server or simply use [Kyuubi Kinit](settings.html#kinit).
-
- ## Deploy Kyuubi Flink Engine on Yarn
-
- ### Requirements
-
- When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
-
- - Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
- - A binary distribution of Flink which is built with YARN support
- - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
- - An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
- - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
- - An active Apache Hadoop HDFS cluster
- - Setup Hadoop client configurations at the machine the Kyuubi server locates
-
- ### Configurations
-
- #### Environment
-
- Either `HADOOP_CONF_DIR` or `YARN_CONF_DIR` is configured and points to the Hadoop client configurations directory, usually, `$HADOOP_HOME/etc/hadoop`.
-
- If the `HADOOP_CONF_DIR` points the YARN and HDFS cluster correctly, and the `HADOOP_CLASSPATH` environment variable is set, you can launch a Flink on YARN session, and submit an example job:
- ```bash
+
+## Deploy Kyuubi Flink Engine on Yarn
+
+### Requirements
+
+When you want to deploy Kyuubi's Flink SQL engines on YARN, you'd better have cognition upon the following things.
+
+- Knowing the basics about [Running Flink on YARN](https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/resource-providers/yarn)
+- A binary distribution of Flink which is built with YARN support
+ - Download a recent Flink distribution from the [Flink official website](https://flink.apache.org/downloads.html) and unpack it
+- An active [Apache Hadoop YARN](https://hadoop.apache.org/docs/current/hadoop-yarn/hadoop-yarn-site/YARN.html) cluster
+ - Make sure your YARN cluster is ready for accepting Flink applications by running yarn top. It should show no error messages
+- An active Apache Hadoop HDFS cluster
Review comment:
Seems does not a hard dependency, can be replaced by Object Storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] KenjiFujima commented on a change in pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
KenjiFujima commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r836980617
##########
File path: docs/deployment/flink/basics.md
##########
@@ -0,0 +1,92 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<div align=center>
+
+
+
+</div>
+
+# Basics
Review comment:
IMO, the `basic.md` is unnecessary for the Flink engine users because the users should have the knowledge of the Flink configuration. And in this document, there is no any content including the Kyuubi Flink engine configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2215: [KYUUBI #2209][FLINK][DOCS] flink detail usage
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#issuecomment-1078979544
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2215](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (246e550) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/fb3e123524fb56c47ab6ffa8756c8ace7a68858a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb3e123) will **increase** coverage by `0.23%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2215 +/- ##
============================================
+ Coverage 61.69% 61.92% +0.23%
Complexity 69 69
============================================
Files 332 331 -1
Lines 15956 16051 +95
Branches 2028 2036 +8
============================================
+ Hits 9844 9940 +96
+ Misses 5291 5282 -9
- Partials 821 829 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.89% <0.00%> (-3.13%)` | :arrow_down: |
| [.../credentials/HadoopFsDelegationTokenProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BGc0RlbGVnYXRpb25Ub2tlblByb3ZpZGVyLnNjYWxh) | `95.00% <0.00%> (-2.30%)` | :arrow_down: |
| [...uubi/engine/spark/operation/ExecuteStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVN0YXRlbWVudC5zY2FsYQ==) | `82.35% <0.00%> (-1.78%)` | :arrow_down: |
| [.../apache/kyuubi/client/KyuubiSyncThriftClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jbGllbnQvS3l1dWJpU3luY1RocmlmdENsaWVudC5zY2FsYQ==) | `87.96% <0.00%> (-1.33%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `96.16% <0.00%> (-0.01%)` | :arrow_down: |
| [...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvU2VydmljZUNvbnRyb2xDbGkuc2NhbGE=) | `77.57% <0.00%> (ø)` | |
| [...kyuubi/engine/spark/schema/IntervalQualifier.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvSW50ZXJ2YWxRdWFsaWZpZXIuc2NhbGE=) | | |
| [...ache/kyuubi/engine/spark/schema/SchemaHelper.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zY2hlbWEvU2NoZW1hSGVscGVyLnNjYWxh) | `94.25% <0.00%> (+0.13%)` | :arrow_up: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `85.59% <0.00%> (+0.24%)` | :arrow_up: |
| [...e/kyuubi/engine/spark/operation/ExecuteScala.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9vcGVyYXRpb24vRXhlY3V0ZVNjYWxhLnNjYWxh) | `83.87% <0.00%> (+1.11%)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb3e123...246e550](https://codecov.io/gh/apache/incubator-kyuubi/pull/2215?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] SteNicholas closed pull request #2215: [KYUUBI #2209] Add detail usage documents of Flink engine
Posted by GitBox <gi...@apache.org>.
SteNicholas closed pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org